Re: [PATCH v5 10/14] perf tools: Enable indices setting syntax for BPF maps

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 10/14] perf tools: Enable indices setting syntax for BPF maps
Date	2015-12-16 09:00 +0100
Message-ID	<qGfa9-7nA-1@gated-at.bofh.it> (permalink)
References	<qFyRz-4Xv-7@gated-at.bofh.it> <qFyRA-4Xv-21@gated-at.bofh.it> <qFY9k-4Mo-11@gated-at.bofh.it> <qG9Hr-429-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Dec 16, 2015 at 10:02:28AM +0800, Wangnan (F) wrote:
> 
> 
> On 2015/12/15 21:42, Jiri Olsa wrote:
> >On Mon, Dec 14, 2015 at 10:39:19AM +0000, Wang Nan wrote:
> >>This patch introduce a new syntax to perf event parser:
> >>
> >>  # perf record -e './test_bpf_map_3.c/maps:channel.value[0,1,2,3...5]=101/' usleep 2
> >why 3 dots? I'd think the standard is 2 ?
> 
> The standard (actually it is a gcc extension, not C standard) is 3 dots.
> Please have a look at [1] and [2]. Although I also think '..' is better.
> 
> So after you seeing this, do you still think we should follow our
> intuition instead of following GCC? If you still prefer '..' I'll
> change it.

I'm ok with '...'

I think I only thought about '..' as a standard because of the way I use git log ;-)

thanks,
jirka

> 
> Thank you.
> 
> [1] https://lkml.org/lkml/2015/11/23/4
> [2] https://gcc.gnu.org/onlinedocs/gcc/Case-Ranges.html
> 
> Thank you.
> 
> >just curious
> >   [0,1,2,3..5]
> >3 made me think there's something speecial about it ;-)
> >
> >
> >jirka
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v5 00/14] perf tools: BPF related update and other improvements Wang Nan <wangnan0@huawei.com> - 2015-12-14 11:50 +0100
  [PATCH v5 08/14] perf tools: Support perf event alias name Wang Nan <wangnan0@huawei.com> - 2015-12-14 11:50 +0100
    Re: [PATCH v5 08/14] perf tools: Support perf event alias name Jiri Olsa <jolsa@redhat.com> - 2015-12-15 14:20 +0100
      Re: [PATCH v5 08/14] perf tools: Support perf event alias name "Wangnan (F)" <wangnan0@huawei.com> - 2015-12-16 03:00 +0100
  [PATCH v5 10/14] perf tools: Enable indices setting syntax for BPF maps Wang Nan <wangnan0@huawei.com> - 2015-12-14 11:50 +0100
    Re: [PATCH v5 10/14] perf tools: Enable indices setting syntax for  BPF maps Jiri Olsa <jolsa@redhat.com> - 2015-12-15 14:50 +0100
      Re: [PATCH v5 10/14] perf tools: Enable indices setting syntax for  BPF maps "Wangnan (F)" <wangnan0@huawei.com> - 2015-12-16 03:10 +0100
        Re: [PATCH v5 10/14] perf tools: Enable indices setting syntax for  BPF maps Jiri Olsa <jolsa@redhat.com> - 2015-12-16 09:00 +0100
    Re: [PATCH v5 10/14] perf tools: Enable indices setting syntax for  BPF maps Jiri Olsa <jolsa@redhat.com> - 2015-12-16 12:30 +0100
  [PATCH v5 05/14] perf tools: Enable BPF object configure syntax Wang Nan <wangnan0@huawei.com> - 2015-12-14 11:50 +0100
    Re: [PATCH v5 05/14] perf tools: Enable BPF object configure syntax Jiri Olsa <jolsa@redhat.com> - 2015-12-15 14:20 +0100
  [PATCH v5 01/14] perf tests: Fix incorrect free and false TEST_OK result Wang Nan <wangnan0@huawei.com> - 2015-12-14 11:50 +0100
  [PATCH v5 09/14] perf tools: Support setting different slots in a BPF map separately Wang Nan <wangnan0@huawei.com> - 2015-12-14 11:50 +0100
  [PATCH v5 13/14] perf tools: Always give options even it not compiled Wang Nan <wangnan0@huawei.com> - 2015-12-14 11:50 +0100
    Re: [PATCH v5 13/14] perf tools: Always give options even it not  compiled Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-12-14 17:10 +0100
    [tip:perf/core] perf tools: Make options always available,   even if required libs not linked tip-bot for Wang Nan <tipbot@zytor.com> - 2015-12-18 10:00 +0100

csiph-web