Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1292782

Re: [PATCH 1/1] powerpc/irq: tidy up inconsistent context in migrate_irqs()

Show all headers | View raw

Hi,

A couple of things.

Firstly, your two email addresses don't match:

Zhang Zhuoyu <hellozzy1988@126.com> writes:
> From: Zhang Zhuoyu <zhangzhuoyu@cmss.chinamobile.com>

These lines do seem odd! Are they causing a problem?

I'd be more comfortable removing them if I understood why they were
added. But they've been around since the beginning of git history so
that could be a bit difficult.

Instead, would it be possible to make sure this doesn't break anything
by including some test results?

Thanks,
Daniel

> Remove paradoxical and unnecessary lines before disable local interrupt.
>
> Signed-off-by: Zhang Zhuoyu <zhangzhuoyu@cmss.chinamobile.com>
> ---
>  arch/powerpc/kernel/irq.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c
> index 290559d..03fa686 100644
> --- a/arch/powerpc/kernel/irq.c
> +++ b/arch/powerpc/kernel/irq.c
> @@ -454,8 +454,6 @@ void migrate_irqs(void)
>  
>  	free_cpumask_var(mask);
>  
> -	local_irq_enable();
> -	mdelay(1);
>  	local_irq_disable();
>  }
>  #endif
> -- 
> 1.8.3.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] powerpc/irq: tidy up inconsistent context in migrate_irqs() Zhang Zhuoyu <hellozzy1988@126.com> - 2015-12-16 06:20 +0100
  Re: [PATCH 1/1] powerpc/irq: tidy up inconsistent context in migrate_irqs() Daniel Axtens <dja@axtens.net> - 2015-12-16 07:10 +0100
    Re: [PATCH 1/1] powerpc/irq: tidy up inconsistent context in  migrate_irqs() Michael Ellerman <mpe@ellerman.id.au> - 2015-12-16 12:40 +0100
      Re: [PATCH 1/1] powerpc/irq: tidy up inconsistent context in migrate_irqs() Denis Kirjanov <kda@linux-powerpc.org> - 2015-12-16 13:00 +0100
        RE: [PATCH 1/1] powerpc/irq: tidy up inconsistent context in migrate_irqs() "Zhang Zhuoyu" <zhangzhuoyu@cmss.chinamobile.com> - 2015-12-16 16:00 +0100
        RE: [PATCH 1/1] powerpc/irq: tidy up inconsistent context in migrate_irqs() "Zhang Zhuoyu" <zhangzhuoyu@cmss.chinamobile.com> - 2015-12-23 03:40 +0100
          Re: [PATCH 1/1] powerpc/irq: tidy up inconsistent context in migrate_irqs() Denis Kirjanov <kda@linux-powerpc.org> - 2015-12-23 23:00 +0100
            RE: [PATCH 1/1] powerpc/irq: tidy up inconsistent context in migrate_irqs() "Zhang Zhuoyu" <zhangzhuoyu@cmss.chinamobile.com> - 2015-12-24 08:10 +0100

csiph-web