Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1294381

[PATCH kernel] vfio: Add explicit alignments in vfio_iommu_spapr_tce_create

Show all headers | View raw

The vfio_iommu_spapr_tce_create struct has 4x32bit and 2x64bit fields
which should have resulted in sizeof(fio_iommu_spapr_tce_create) equal
to 32 bytes. However due to the gcc's default alignment, the actual
size of this struct is 40 bytes.

This fills gaps with __resv1/2 fields.

This should not cause any change in behavior.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 include/uapi/linux/vfio.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h
index 9fd7b5d..d117233 100644
--- a/include/uapi/linux/vfio.h
+++ b/include/uapi/linux/vfio.h
@@ -568,8 +568,10 @@ struct vfio_iommu_spapr_tce_create {
 	__u32 flags;
 	/* in */
 	__u32 page_shift;
+	__u32 __resv1;
 	__u64 window_size;
 	__u32 levels;
+	__u32 __resv2;
 	/* out */
 	__u64 start_addr;
 };
-- 
2.5.0.rc3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH kernel] vfio: Add explicit alignments in vfio_iommu_spapr_tce_create Alexey Kardashevskiy <aik@ozlabs.ru> - 2015-12-18 02:40 +0100
  Re: [PATCH kernel] vfio: Add explicit alignments in  vfio_iommu_spapr_tce_create David Gibson <david@gibson.dropbear.id.au> - 2015-12-21 02:00 +0100
  Re: [PATCH kernel] vfio: Add explicit alignments in  vfio_iommu_spapr_tce_create Alex Williamson <alex.williamson@redhat.com> - 2015-12-22 21:10 +0100

csiph-web