Re: [PATCHv6 6/7] aer_inject: Use 32 bit int type domains

From	Keith Busch <keith.busch@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv6 6/7] aer_inject: Use 32 bit int type domains
Date	2015-12-17 19:20 +0100
Message-ID	<qGLjI-2Xy-13@gated-at.bofh.it> (permalink)
References	<qDbFL-1D6-7@gated-at.bofh.it> <qDbFM-1D6-39@gated-at.bofh.it> <qGKQH-2xR-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Dec 17, 2015 at 11:46:15AM -0600, Bjorn Helgaas wrote:
> On Mon, Dec 07, 2015 at 02:32:28PM -0700, Keith Busch wrote:
> > -	u16 domain;
> > +	int domain;
> 
> If you want 32 bits explicitly, why don't you use u32 here?

It matches the types already defined in struct pci_dev and the
pci_domain_nr return value.

Would you prefer changing all of them to u32, just aer_inject's, or
leave as-is?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCHv6 6/7] aer_inject: Use 32 bit int type domains Bjorn Helgaas <helgaas@kernel.org> - 2015-12-17 18:50 +0100
  Re: [PATCHv6 6/7] aer_inject: Use 32 bit int type domains Keith Busch <keith.busch@intel.com> - 2015-12-17 19:20 +0100

csiph-web