Re: [PATCH] use callbacks to access UART_DLL/UART_DLM

From	Måns Rullgård <mans@mansr.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] use callbacks to access UART_DLL/UART_DLM
Date	2015-12-17 19:10 +0100
Message-ID	<qGLa3-2TY-19@gated-at.bofh.it> (permalink)
References	<qGJhT-1Gz-5@gated-at.bofh.it> <qGJhT-1Gz-9@gated-at.bofh.it> <qGLa2-2TY-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Sebastian Frias <sf84@laposte.net> writes:

>>>        old_lcr = serial_in(p, UART_LCR);
>>> -    serial_out(p, UART_LCR, UART_LCR_CONF_MODE_A);
>>> -
>>> -    old_dll = serial_in(p, UART_DLL);
>>> -    old_dlm = serial_in(p, UART_DLM);
>>>
>>> -    serial_out(p, UART_DLL, 0);
>>> -    serial_out(p, UART_DLM, 0);
>>> +    serial_out(p, UART_LCR, UART_LCR_CONF_MODE_A);
>>>
>>> -    id = serial_in(p, UART_DLL) | serial_in(p, UART_DLM) << 8;
>>> +    old_dl = serial_dl_read(p);
>>> +    serial_dl_write(p, 0);
>>> +    id = serial_dl_read(p);
>>> +    serial_dl_write(p, old_dl);
>>>
>>> -    serial_out(p, UART_DLL, old_dll);
>>> -    serial_out(p, UART_DLM, old_dlm);
>>>        serial_out(p, UART_LCR, old_lcr);
>>>
>>>        return id;
>>> --
>>
>> If you left the blank lines alone, the patch would end up much easier to
>> understand.  In this diff, some of the lines listed as added or removed
>> have actually not changed, and that's not immediately obvious.
>>
>
> The old code had some blank lines, which I suppose were there for clarity.
> I attempted to follow the same idea.
> But I don't mind changing the code as you wish.

It could well be that your patch results in a clearer final version, but
the diff is harder to parse when unchanged lines have moved around.

-- 
Måns Rullgård
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] use callbacks to access UART_DLL/UART_DLM Måns Rullgård <mans@mansr.com> - 2015-12-17 17:10 +0100
  Re: [PATCH] use callbacks to access UART_DLL/UART_DLM Måns Rullgård <mans@mansr.com> - 2015-12-17 19:10 +0100
    Re: [PATCH] use callbacks to access UART_DLL/UART_DLM Mason <slash.tmp@free.fr> - 2015-12-17 20:20 +0100
  Re: [PATCH] use callbacks to access UART_DLL/UART_DLM Sebastian Frias <sf84@laposte.net> - 2015-12-17 19:10 +0100
    [PATCH v2] use callbacks to access UART_DLL/UART_DLM Sebastian Frias <sf84@laposte.net> - 2015-12-18 11:50 +0100
      Re: [PATCH v2] use callbacks to access UART_DLL/UART_DLM Peter Hurley <peter@hurleysoftware.com> - 2015-12-18 17:10 +0100
        Re: [PATCH v2] use callbacks to access UART_DLL/UART_DLM Sebastian Frias <sf84@laposte.net> - 2015-12-18 17:30 +0100
          Re: [PATCH v2] use callbacks to access UART_DLL/UART_DLM Sebastian Frias <sf84@laposte.net> - 2015-12-18 17:40 +0100
          Re: [PATCH v2] use callbacks to access UART_DLL/UART_DLM Peter Hurley <peter@hurleysoftware.com> - 2015-12-18 17:40 +0100
        Re: [PATCH v3] use callbacks to access UART_DLL/UART_DLM Peter Hurley <peter@hurleysoftware.com> - 2015-12-18 17:50 +0100
        [PATCH v3] use callbacks to access UART_DLL/UART_DLM Sebastian Frias <sf84@laposte.net> - 2015-12-18 17:50 +0100

csiph-web