Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1294102

Re: -next regression: "driver cohandle -EPROBE_DEFER from bus_type.match()"

Show all headers | View raw

On Thu, Dec 17, 2015 at 8:51 AM, Dan Williams <dan.j.williams@intel.com> wrote:
> The commit below causes the libnvdimm sub-system to stop loading.
> This is due to the fact that nvdimm_bus_match() returns the result of
> test_bit() which may be negative.  If there are any other bus match
> functions using test_bit they may be similarly impacted.
>
> Can we queue a fixup like the following to libnvdimm, and maybe
> others, ahead of this driver core change?
>
> diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c
> index 7e2c43f701bc..2b2181cdeb63 100644
> --- a/drivers/nvdimm/bus.c
> +++ b/drivers/nvdimm/bus.c
> @@ -62,7 +62,7 @@ static int nvdimm_bus_match(struct device *dev,
> struct device_driver *drv)
> {
>        struct nd_device_driver *nd_drv = to_nd_device_driver(drv);
>
> -       return test_bit(to_nd_device_type(dev), &nd_drv->type);
> +       return !!test_bit(to_nd_device_type(dev), &nd_drv->type);

How is this call to test_bit() returning a negative value?  That can
only happen if the bit number we supply is 63, correct?  I only see
to_nd_device_type() returning 1-6 for the defines ND_DEVICE_DIMM thru
ND_DEVICE_NAMESPACE_BLK?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

-next regression: "driver cohandle -EPROBE_DEFER from bus_type.match()" Dan Williams <dan.j.williams@intel.com> - 2015-12-17 17:00 +0100
  Re: -next regression: "driver cohandle -EPROBE_DEFER from bus_type.match()" Dan Williams <dan.j.williams@intel.com> - 2015-12-17 17:50 +0100
    Re: -next regression: "driver cohandle -EPROBE_DEFER from  bus_type.match()" Matthew Wilcox <willy@linux.intel.com> - 2015-12-17 18:10 +0100
  Re: -next regression: "driver cohandle -EPROBE_DEFER from bus_type.match()" Ross Zwisler <zwisler@gmail.com> - 2015-12-17 19:00 +0100
  Re: -next regression: "driver cohandle -EPROBE_DEFER from  bus_type.match()" Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-17 19:50 +0100
    Re: -next regression: "driver cohandle -EPROBE_DEFER from bus_type.match()" Dan Williams <dan.j.williams@intel.com> - 2015-12-17 21:40 +0100
    Re: -next regression: "driver cohandle -EPROBE_DEFER from bus_type.match()" Yoshinori Sato <ysato@users.sourceforge.jp> - 2015-12-18 05:20 +0100
    Re: -next regression:  "driver cohandle -EPROBE_DEFER from bus_type.match()" Marek Szyprowski <m.szyprowski@samsung.com> - 2015-12-18 15:30 +0100

csiph-web