[PATCH v2 1/1] rtc: Replace simple_strtoul by kstrtoul

Path	csiph.com!au2pb.net!feeder.erje.net!1.eu.feeder.erje.net!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	LABBE Corentin <clabbe.montjoie@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 1/1] rtc: Replace simple_strtoul by kstrtoul
Date	Thu, 17 Dec 2015 14:20:02 +0100
Message-ID	<qGGDo-8kx-17@gated-at.bofh.it> (permalink)
References	<qGGDo-8kx-19@gated-at.bofh.it>
X-Original-To	alexandre.belloni@free-electrons.com, a.zummo@towertech.it
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cOXJbxWrBdTPmqY7+tNTAliGgxDq0e6yoO6izUXfQq0=; b=dNusi3Rql9GDhGJDPZTD64i+mmhNEkX7WoKgg2LOsiCf36BohTa0yIuhD7NMw7xKoe ydta7n4bnV/mnEWIQD1SqLM1es+UFjaL5M8k+y8Wt7GpEiRE6ggO0oGOiZsko22OGvUI zOeuapWm22WYovZzBjTZhL5fnJyLyoWFQOTb7+3VdJO4sagSUepOLVpIndNxB3gnrmci y7TMt7+Qqjy/q4WjTHbeghuFQDjSvZykf7fdVvwe8dQrtmTvMfMl8uohXD49eaS58ksZ dlo9cSSCKEJ4iaIxFmjCtG2HY61DMF2vhODCzLOGe0px+b1nEBVl9lGRLw/7sITJDbV6 vGcg==
X-Received	by 10.194.88.200 with SMTP id bi8mr66563245wjb.178.1450357872556; Thu, 17 Dec 2015 05:11:12 -0800 (PST)
X-Mailer	git-send-email 2.4.10
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	51
Organization	linux.* mail to news gateway
X-Original-Cc	LABBE Corentin <clabbe.montjoie@gmail.com>, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com
X-Original-Date	Thu, 17 Dec 2015 14:11:04 +0100
X-Original-Message-ID	<1450357864-7852-2-git-send-email-clabbe.montjoie@gmail.com>
X-Original-References	<1450357864-7852-1-git-send-email-clabbe.montjoie@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1293878

Show key headers only | View raw

The simple_strtoul function is obsolete.
This patch replace it by kstrtoul.

Since kstrtoul is more strict, it permits to filter some invalid input that
simple_strtoul accept. For example:
echo '1022xxx' > /sys/devices/pnp0/00:03/rtc/rtc0/max_user_freq
cat /sys/devices/pnp0/00:03/rtc/rtc0/max_user_freq
1022

Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
 drivers/rtc/rtc-sysfs.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-sysfs.c b/drivers/rtc/rtc-sysfs.c
index 7273855..463e286 100644
--- a/drivers/rtc/rtc-sysfs.c
+++ b/drivers/rtc/rtc-sysfs.c
@@ -91,7 +91,12 @@ max_user_freq_store(struct device *dev, struct device_attribute *attr,
 		const char *buf, size_t n)
 {
 	struct rtc_device *rtc = to_rtc_device(dev);
-	unsigned long val = simple_strtoul(buf, NULL, 0);
+	unsigned long val;
+	int err;
+
+	err = kstrtoul(buf, 0, &val);
+	if (err)
+		return err;
 
 	if (val >= 4096 || val == 0)
 		return -EINVAL;
@@ -175,7 +180,9 @@ wakealarm_store(struct device *dev, struct device_attribute *attr,
 		} else
 			adjust = 1;
 	}
-	alarm = simple_strtoul(buf_ptr, NULL, 0);
+	retval = kstrtoul(buf_ptr, 0, &alarm);
+	if (retval)
+		return retval;
 	if (adjust) {
 		alarm += now;
 	}
-- 
2.4.10

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/1] rtc: Replace simple_strtoul by kstrtoul LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-12-17 14:20 +0100
  Re: [PATCH v2 1/1] rtc: Replace simple_strtoul by kstrtoul Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-12-17 14:40 +0100
  Re: [PATCH v2 1/1] rtc: Replace simple_strtoul by kstrtoul Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-12-22 20:10 +0100

csiph-web