Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1293789

Re: [PATCH v4] spi: dts: sun4i: Add support for wait time between word transmissions

Show all headers | View raw

Hi Maxime,

2015-12-16 11:39 GMT+01:00 Maxime Ripard <maxime.ripard@free-electrons.com>:
> It looks mostly fine, however, please try to make only one thing in
> one patch.
>
> In this case, it would mean having one patch to add the DT property
> and support in the SPI core in a first one, and then add support for
> it in your driver.

Will do.

> I also have a minor comment below....
[...]
>> +     if (spi->word_wait_ns) {
>> +             clk_ns = DIV_ROUND_UP(1000000000, tfr->speed_hz);
>> +             wait_clk = DIV_ROUND_UP(spi->word_wait_ns, clk_ns) - 3;
>> +             if (wait_clk < 1) {
>> +                     wait_clk = 1;
>> +                     dev_info(&spi->dev,
>> +                              "using minimum of 4 word wait cycles (%uns)",
>> +                              4 * clk_ns);
>
> Logging it at the info loglevel seems a bit too high. debug seems more
> appropriate.

I will change it to debug and send a new version.

Thanks for the review!

Marcus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4] spi: dts: sun4i: Add support for wait time between word transmissions Marcus Weseloh <mweseloh42@gmail.com> - 2015-12-14 09:20 +0100
  Re: [PATCH v4] spi: dts: sun4i: Add support for wait time between  word transmissions Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-12-16 11:40 +0100
    Re: [PATCH v4] spi: dts: sun4i: Add support for wait time between  word transmissions Marcus Weseloh <mweseloh42@gmail.com> - 2015-12-17 12:30 +0100

csiph-web