[PATCH 3/3] regcache: flat: Introduce regcache_get_index()

Path	csiph.com!au2pb.net!feeder.erje.net!2.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!feeds.phibee-telecom.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Xiubo Li <lixiubo@cmss.chinamobile.com>
Newsgroups	linux.kernel
Subject	[PATCH 3/3] regcache: flat: Introduce regcache_get_index()
Date	Thu, 17 Dec 2015 09:50:03 +0100
Message-ID	<qGCq7-5pv-29@gated-at.bofh.it> (permalink)
References	<qGCq6-5pv-5@gated-at.bofh.it>
X-Original-To	broonie@kernel.org
X-Rm-Transid	2ee75672760920b-969a4
X-Rm-Spam-Flag	00000000
X-Rm-Transid	2ee456727608248-818ec
X-Mailer	git-send-email 1.9.1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	63
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, Xiubo Li <lixiubo@cmss.chinamobile.com>
X-Original-Date	Thu, 17 Dec 2015 16:45:30 +0800
X-Original-Message-ID	<1450341930-5090-4-git-send-email-lixiubo@cmss.chinamobile.com>
X-Original-References	<1450341930-5090-1-git-send-email-lixiubo@cmss.chinamobile.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1293683

Show key headers only | View raw

Here we introduce regcache_get_index(), which using register stride
order and bit rotation, will save some memory spaces for flat cache.
Though this will also lost some access performance, since the bit
rotation is used to get the index of the cache array, and this could
be ingored for memory I/O accessing.

Signed-off-by: Xiubo Li <lixiubo@cmss.chinamobile.com>
---
 drivers/base/regmap/regcache-flat.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/base/regmap/regcache-flat.c b/drivers/base/regmap/regcache-flat.c
index 686c9e0..218cf39 100644
--- a/drivers/base/regmap/regcache-flat.c
+++ b/drivers/base/regmap/regcache-flat.c
@@ -21,15 +21,16 @@ static int regcache_flat_init(struct regmap *map)
 	int i;
 	unsigned int *cache;
 
-	map->cache = kcalloc(map->max_register + 1, sizeof(unsigned int),
-			     GFP_KERNEL);
+	map->cache = kcalloc(regcache_get_index(map, map->max_register) + 1,
+			     sizeof(unsigned int), GFP_KERNEL);
 	if (!map->cache)
 		return -ENOMEM;
 
 	cache = map->cache;
 
 	for (i = 0; i < map->num_reg_defaults; i++)
-		cache[map->reg_defaults[i].reg] = map->reg_defaults[i].def;
+		cache[regcache_get_index(map, map->reg_defaults[i].reg)] =
+				map->reg_defaults[i].def;
 
 	return 0;
 }
@@ -47,7 +48,7 @@ static int regcache_flat_read(struct regmap *map,
 {
 	unsigned int *cache = map->cache;
 
-	*value = cache[reg];
+	*value = cache[regcache_get_index(map, reg)];
 
 	return 0;
 }
@@ -57,7 +58,7 @@ static int regcache_flat_write(struct regmap *map, unsigned int reg,
 {
 	unsigned int *cache = map->cache;
 
-	cache[reg] = value;
+	cache[regcache_get_index(map, reg)] = value;
 
 	return 0;
 }
-- 
1.8.3.1



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Introduce reg stride order  Xiubo Li <lixiubo@cmss.chinamobile.com> - 2015-12-17 09:50 +0100
  [PATCH 3/3] regcache: flat: Introduce regcache_get_index() Xiubo Li <lixiubo@cmss.chinamobile.com> - 2015-12-17 09:50 +0100

csiph-web