Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1292591

Re: [PATCH trivial] include: asm-generic: Notice about 80 columns in pgtable-no*.h

Show all headers | View raw

On 12/16/15 04:26, Joe Perches wrote:
> On Tue, 2015-12-15 at 22:15 +0800, Chen Gang wrote:
>> It is a trivial patch.
> []
>> diff --git a/include/asm-generic/pgtable-nopmd.h b/include/asm-generic/pgtable-nopmd.h
> []
>> @@ -38,7 +38,8 @@ static inline void pud_clear(pud_t *pud)	{ }
>>   * (pmds are folded into puds so this doesn't get actually called,
>>   * but the define is needed for a generic inline function.)
>>   */
>> -#define set_pud(pudptr, pudval)			set_pmd((pmd_t *)(pudptr), (pmd_t) { pudval })
>> +#define set_pud(pudptr, pudval)			(set_pmd((pmd_t *)(pudptr), \
>> +							(pmd_t) { pudval }))
> 
> Not quite so trivial.
> 
> If you _really_ want to break this up for 80 columns,
> and I don't think it's necessary, it might be better
> to use something like:
> 
> #define set_pud(pudptr, pudval)					\
> 	set_pmd((pmd_t *)(pudptr), (pmd_t) { pudval })
>

OK, thanks. For me, it is better. 

-- 
Chen Gang (陈刚)

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH trivial] include: asm-generic: Notice about 80 columns in  pgtable-no*.h Chen Gang <chengang@emindsoft.com.cn> - 2015-12-15 15:20 +0100
  Re: [PATCH trivial] include: asm-generic: Notice about 80 columns in  pgtable-no*.h kbuild test robot <lkp@intel.com> - 2015-12-15 16:40 +0100
  Re: [PATCH trivial] include: asm-generic: Notice about 80 columns in  pgtable-no*.h kbuild test robot <lkp@intel.com> - 2015-12-15 16:50 +0100
    Re: [PATCH trivial] include: asm-generic: Notice about 80 columns in pgtable-no*.h Arnd Bergmann <arnd@arndb.de> - 2015-12-15 17:00 +0100
      Re: [PATCH trivial] include: asm-generic: Notice about 80 columns  in pgtable-no*.h Chen Gang <chengang@emindsoft.com.cn> - 2015-12-15 23:10 +0100
  Re: [PATCH trivial] include: asm-generic: Notice about 80 columns  in pgtable-no*.h Joe Perches <joe@perches.com> - 2015-12-15 21:30 +0100
    Re: [PATCH trivial] include: asm-generic: Notice about 80 columns  in pgtable-no*.h Chen Gang <chengang@emindsoft.com.cn> - 2015-12-15 23:10 +0100
  Re: [PATCH trivial] include: asm-generic: Notice about 80 columns in  pgtable-no*.h kbuild test robot <lkp@intel.com> - 2015-12-15 21:40 +0100

csiph-web