Re: [PATCH RESEND 22/27] tools/hv: Use include/uapi with __EXPORTED_HEADERS__

From	Kamal Mostafa <kamal@canonical.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH RESEND 22/27] tools/hv: Use include/uapi with __EXPORTED_HEADERS__
Date	2015-12-15 19:20 +0100
Message-ID	<qG2mB-7LE-1@gated-at.bofh.it> (permalink)
References	<qFJN1-3NK-19@gated-at.bofh.it> <qFJN1-3NK-17@gated-at.bofh.it> <qFJWH-3Ss-43@gated-at.bofh.it> <qFOjE-6RA-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2015-12-14 at 19:11 -0800, Greg KH wrote:
> On Mon, Dec 14, 2015 at 04:01:53PM -0800, K. Y. Srinivasan wrote:
> > From: Kamal Mostafa <kamal@canonical.com>
> > 
> > Use the local uapi headers to keep in sync with "recently" added #define's
> > (e.g. VSS_OP_REGISTER1).
> > 
> > Fixes: 3eb2094c59e89db2bedd401e23c7a870081c9edb
> 
> Please use the "correct" way of listing this:
> 	3eb2094c59e8 ("Adding makefile for tools/hv")
> 
> And as this is an old kernel, shouldn't it go into stable releases?

Yes it should.  I'll resubmit with Cc: stable and correct the Fixes
line.

>   Or
> does that mean that no one really ever runs into this issue?
> 
> > Signed-off-by: Kamal Mostafa <kamal@canonical.com>
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > ---
> >  tools/hv/Makefile |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/tools/hv/Makefile b/tools/hv/Makefile
> > index a8ab795..a8c4644 100644
> > --- a/tools/hv/Makefile
> > +++ b/tools/hv/Makefile
> > @@ -5,6 +5,8 @@ PTHREAD_LIBS = -lpthread
> >  WARNINGS = -Wall -Wextra
> >  CFLAGS = $(WARNINGS) -g $(PTHREAD_LIBS) $(shell getconf LFS_CFLAGS)
> >  
> > +CFLAGS += -D__EXPORTED_HEADERS__ -I../../include/uapi -I../../include
> 
> Why do you need ../../include also?

Because include/uapi/linux/stddef.h includes linux/compiler.h, so
omitting ../../include yields:

gcc -Wall -Wextra -g -lpthread  -D__EXPORTED_HEADERS__ -I../../include/uapi  -o hv_kvp_daemon hv_kvp_daemon.c
In file included from ../../include/uapi/linux/posix_types.h:4:0,
                 from ../../include/uapi/linux/types.h:13,
                 from ../../include/uapi/linux/uuid.h:24,
                 from ../../include/uapi/linux/hyperv.h:28,
                 from hv_kvp_daemon.c:36:
../../include/uapi/linux/stddef.h:1:28: fatal error: linux/compiler.h: No such file or directory
 #include <linux/compiler.h>
                            ^

 -Kamal

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH RESEND 01/27] Drivers: hv: util: Increase the timeout for util services "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:30 +0100
  [PATCH RESEND 02/27] Drivers: hv: utils: run polling callback always in interrupt context "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:30 +0100
  [PATCH RESEND 03/27] tools: hv: report ENOSPC errors in hv_fcopy_daemon "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:30 +0100
  [PATCH RESEND 06/27] Drivers: hv: utils: use memdup_user in hvt_op_write "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:30 +0100
  [PATCH RESEND 04/27] tools: hv: remove repeated HV_FCOPY string "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:30 +0100
  [PATCH RESEND 10/27] drivers:hv: Define the channel type for Hyper-V PCI Express pass-through "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:40 +0100
  [PATCH RESEND 09/27] drivers:hv: Export the API to invoke a hypercall on Hyper-V "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:40 +0100
    Re: [PATCH RESEND 09/27] drivers:hv: Export the API to invoke a  hypercall on Hyper-V Greg KH <gregkh@linuxfoundation.org> - 2015-12-15 04:10 +0100
      RE: [PATCH RESEND 09/27] drivers:hv: Export the API to invoke a  hypercall on Hyper-V KY Srinivasan <kys@microsoft.com> - 2015-12-15 05:20 +0100
  [PATCH RESEND 14/27] Drivers: hv: vmbus: Get rid of the unused macro "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:40 +0100
  [PATCH RESEND 20/27] Drivers: hv: vmbus: channge vmbus_connection.channel_lock to mutex "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:40 +0100
  [PATCH RESEND 26/27] Drivers: hv: utils: Invoke the poll function after handshake "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:40 +0100
  [PATCH RESEND 05/27] Drivers: hv: util: catch allocation errors "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:40 +0100
  [PATCH RESEND 08/27] drivers:hv: Export a function that maps Linux CPU num onto Hyper-V proc num "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:40 +0100
  [PATCH RESEND 07/27] drivers/hv: cleanup synic msrs if vmbus connect failed "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:40 +0100
  [PATCH RESEND 22/27] tools/hv: Use include/uapi with __EXPORTED_HEADERS__ "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:40 +0100
    Re: [PATCH RESEND 22/27] tools/hv: Use include/uapi with  __EXPORTED_HEADERS__ Greg KH <gregkh@linuxfoundation.org> - 2015-12-15 04:20 +0100
      Re: [PATCH RESEND 22/27] tools/hv: Use include/uapi with  __EXPORTED_HEADERS__ Kamal Mostafa <kamal@canonical.com> - 2015-12-15 19:20 +0100
        [PATCH v2] tools/hv: Use include/uapi with __EXPORTED_HEADERS__ Kamal Mostafa <kamal@canonical.com> - 2015-12-15 19:30 +0100
          Re: [PATCH v2] tools/hv: Use include/uapi with __EXPORTED_HEADERS__ Greg KH <gregkh@linuxfoundation.org> - 2015-12-15 19:50 +0100
  [PATCH RESEND 25/27] Drivers: hv: vmbus: Force all channel messages to be delivered on CPU 0 "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:40 +0100
  [PATCH RESEND 21/27] drivers:hv: Allow for MMIO claims that span ACPI _CRS records "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:40 +0100
  [PATCH RESEND 24/27] drivers/hv: correct tsc page sequence invalid value "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:40 +0100
  [PATCH RESEND 11/27] Drivers: hv: vss: run only on supported host versions "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:40 +0100
  [PATCH RESEND 27/27] tools: hv: vss: fix the write()'s argument: error -> vss_msg "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:40 +0100
  [PATCH RESEND 16/27] Drivers: hv: vmbus: serialize process_chn_event() and vmbus_close_internal() "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:40 +0100
  [PATCH RESEND 18/27] Drivers: hv: vmbus: fix rescind-offer handling for device without a driver "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:40 +0100
  [PATCH RESEND 19/27] Drivers: hv: vmbus: release relid on error in vmbus_process_offer() "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:40 +0100
  [PATCH RESEND 23/27] Drivers: hv: vmbus: Fix a Host signaling bug "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:40 +0100
  [PATCH RESEND 17/27] Drivers: hv: vmbus: do sanity check of channel state in vmbus_close_internal() "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:50 +0100
  [PATCH RESEND 13/27] Drivers: hv: vmbus: Use uuid_le_cmp() for comparing GUIDs "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:50 +0100
  [PATCH RESEND 12/27] Drivers: hv: vmbus: Use uuid_le type consistently "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:50 +0100
  [PATCH RESEND 15/27] Drivers: hv: vmbus: Get rid of the unused irq variable "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-14 23:50 +0100

csiph-web