Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1291110

Re: [PATCH 10/10] fs: make quota/dquot.c explicitly non-modular

Show all headers | View raw

On Sat 12-12-15 16:30:12, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> config QUOTA
>         bool "Quota support"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the couple traces of modularity so that when reading the
> driver there is no doubt it is builtin-only.
> 
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering gets bumped to one level earlier when we
> use the more appropriate fs_initcall here.  However we've made similar
> changes before without any fallout and none is expected here either.
> 
> We don't delete module.h because the code in turn tries to load other
> modules as appropriate and so it still needs that header.

Looks good. I have taken the patch to my tree.

								Honza
> 
> Cc: Jan Kara <jack@suse.com>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: linux-fsdevel@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>  fs/quota/dquot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
> index ef0d64b2a6d9..fbd70af98820 100644
> --- a/fs/quota/dquot.c
> +++ b/fs/quota/dquot.c
> @@ -2924,4 +2924,4 @@ static int __init dquot_init(void)
>  
>  	return 0;
>  }
> -module_init(dquot_init);
> +fs_initcall(dquot_init);
> -- 
> 2.6.1
> 
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 10/10] fs: make quota/dquot.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-12-12 22:40 +0100
  Re: [PATCH 10/10] fs: make quota/dquot.c explicitly non-modular Jan Kara <jack@suse.cz> - 2015-12-14 12:10 +0100

csiph-web