Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1291108

Re: [PATCH 02/10] fs: make quota/netlink.c explicitly non-modular

From Jan Kara <jack@suse.cz>
Newsgroups linux.kernel
Subject Re: [PATCH 02/10] fs: make quota/netlink.c explicitly non-modular
Date 2015-12-14 12:10 +0100
Message-ID <qFzaV-5m6-3@gated-at.bofh.it> (permalink)
References <qF03v-7Ik-3@gated-at.bofh.it> <qF03w-7Ik-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat 12-12-15 16:30:04, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> config QUOTA_NETLINK_INTERFACE
>         bool "Report quota messages through netlink interface"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the couple traces of modularity so that when reading the
> driver there is no doubt it is builtin-only.
> 
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering gets bumped to one level earlier when we
> use the more appropriate fs_initcall here.  However we've made similar
> changes before without any fallout and none is expected here either.
> 
> Cc: Jan Kara <jack@suse.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Looks good. I have taken the patch into my tree.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 02/10] fs: make quota/netlink.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-12-12 22:40 +0100
  Re: [PATCH 02/10] fs: make quota/netlink.c explicitly non-modular Jan Kara <jack@suse.cz> - 2015-12-14 12:10 +0100

csiph-web