Re: [PATCH 00/10] drivers/pci: avoid module_init in non-modular host/pci*

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 00/10] drivers/pci: avoid module_init in non-modular host/pci*
Date	2015-12-14 11:30 +0100
Message-ID	<qFyyf-4PE-31@gated-at.bofh.it> (permalink)
References	<qF3Xr-1IU-3@gated-at.bofh.it> <qFwPM-3DO-21@gated-at.bofh.it> <qFxst-47d-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Monday 14 December 2015 10:19:40 Thierry Reding wrote:
> > PCIe host driver that use fixup (DECLARE_PCI_FIXUP_*) can't use tristate.
> > Fixup region is in kernel region and this region if not updated when
> > loading a module.
> 
> Interesting, I hadn't thought about that. I suppose this means that the
> module will end up containing an unused section with the fixup code. It
> might be useful to add a way for that to trigger a warning at build
> time.
> 
> Perhaps to fix this a mechanism could be introduced to add a table of
> fixups to a host controller driver and that will get applied to all
> children of the bridge. It could be problematic to cover all of the
> different fixup stages, though.
> 


I think a lot of the fixups shouldn't really be there in the first place,
they are about stuff that we can fix up in the probe function, or that should
be fixed up in the probe function with some appropriate core support added.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 00/10] drivers/pci: avoid module_init in non-modular host/pci* Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-12-13 02:50 +0100
  Re: [PATCH 00/10] drivers/pci: avoid module_init in non-modular host/pci* Geert Uytterhoeven <geert@linux-m68k.org> - 2015-12-14 09:20 +0100
    Re: [PATCH 00/10] drivers/pci: avoid module_init in non-modular  host/pci* Thierry Reding <thierry.reding@gmail.com> - 2015-12-14 09:30 +0100
      Re: [PATCH 00/10] drivers/pci: avoid module_init in non-modular  host/pci* Michal Simek <michal.simek@xilinx.com> - 2015-12-14 09:30 +0100
      Re: [PATCH 00/10] drivers/pci: avoid module_init in non-modular host/pci* Ley Foon Tan <lftan@altera.com> - 2015-12-14 09:40 +0100
        Re: [PATCH 00/10] drivers/pci: avoid module_init in non-modular  host/pci* Thierry Reding <thierry.reding@gmail.com> - 2015-12-14 10:20 +0100
          Re: [PATCH 00/10] drivers/pci: avoid module_init in non-modular host/pci* Arnd Bergmann <arnd@arndb.de> - 2015-12-14 11:30 +0100
            Re: [PATCH 00/10] drivers/pci: avoid module_init in non-modular  host/pci* Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-12-15 16:20 +0100

csiph-web