Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs
Date	2015-12-14 11:10 +0100
Message-ID	<qFyeT-4Fp-15@gated-at.bofh.it> (permalink)
References	<qyqvL-3iT-5@gated-at.bofh.it> <qyqvM-3iT-23@gated-at.bofh.it> <qDb34-14n-15@gated-at.bofh.it> <qDbcJ-1od-11@gated-at.bofh.it> <qDbFN-1D6-47@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2015-12-07 at 16:33 -0500, Steven Rostedt wrote:
> On Tue, 08 Dec 2015 08:02:15 +1100
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> > On Mon, 2015-12-07 at 15:52 -0500, Steven Rostedt wrote:
> > > > +     TP_CONDITION(cpu_online(smp_processor_id())),
> > > > +  
> > 
> > This should probably be some kind of __raw version though, hcalls can
> > be called in contexts where the debug stuff in smp_processor_id() isn't
> > safe (or preempt enabled).
> > 
> 
> OK, then that needs to be updated.

Denis, please respin with raw_smp_processor_id().

cheers

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs Michael Ellerman <mpe@ellerman.id.au> - 2015-12-14 11:10 +0100
  Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs Denis Kirjanov <kda@linux-powerpc.org> - 2015-12-14 11:10 +0100

csiph-web