Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1290901

Re: [PATCH v3] spi: dts: sun4i: Add support for hardware-based wait time between words

Show all headers | View raw

Hi,

2015-12-14 2:29 GMT+01:00 Rob Herring <robh@kernel.org>:
> On Mon, Dec 14, 2015 at 12:04:11AM +0100, Marcus Weseloh wrote:
>> Adds a new property "spi-word-wait-ns" to the spi-bus binding that allows
[...]
>> diff --git a/Documentation/devicetree/bindings/spi/spi-bus.txt b/Documentation/devicetree/bindings/spi/spi-bus.txt
>> index bbaa857..2d6034f 100644
>> --- a/Documentation/devicetree/bindings/spi/spi-bus.txt
>> +++ b/Documentation/devicetree/bindings/spi/spi-bus.txt
>> @@ -61,6 +61,8 @@ contain the following properties.
>>                        used for MOSI. Defaults to 1 if not present.
>>  - spi-rx-bus-width - (optional) The bus width(number of data wires) that
>>                        used for MISO. Defaults to 1 if not present.
>> +- spi-word-wait-ns - (optional) Hardware based delay between transmission of
>> +                      words in nanoseconds
>
> Could be a software delay if the h/w doesn't support delays.

Of course, I was still trapped in my sun4i specific thinking. Will
remove the hardware reference.

[...]
>> +     /* Setup wait time between words */
>> +     of_property_read_u32(spi->dev.of_node, "spi-word-wait-ns",
>> +                          &wait_ns);
>
> Read this in probe and save the value rather than fetching every
> transfer.

But this is a slave property I'm using here. If I read and store it in
probe in the spi-sun4i driver, I won't have access to the slave node
property, will I?

Cheers,

    Marcus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] spi: dts: sun4i: Add support for hardware-based wait time between words Marcus Weseloh <mweseloh42@gmail.com> - 2015-12-14 00:10 +0100
  Re: [PATCH v3] spi: dts: sun4i: Add support for hardware-based wait  time between words Rob Herring <robh@kernel.org> - 2015-12-14 02:40 +0100
    Re: [PATCH v3] spi: dts: sun4i: Add support for hardware-based wait  time between words Marcus Weseloh <mweseloh42@gmail.com> - 2015-12-14 08:40 +0100
      Re: [PATCH v3] spi: dts: sun4i: Add support for hardware-based wait  time between words Marcus Weseloh <mweseloh42@gmail.com> - 2015-12-14 09:10 +0100

csiph-web