Re: [PATCH 07/10] drivers/pci: make host/pcie-rcar.c explicitly non-modular

From	Simon Horman <horms@verge.net.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH 07/10] drivers/pci: make host/pcie-rcar.c explicitly non-modular
Date	2015-12-14 06:20 +0100
Message-ID	<qFtId-1Fa-9@gated-at.bofh.it> (permalink)
References	<qF3Xr-1IU-3@gated-at.bofh.it> <qF3Xs-1IU-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Dec 12, 2015 at 08:41:54PM -0500, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> drivers/pci/host/Kconfig:config PCI_RCAR_GEN2_PCIE
> drivers/pci/host/Kconfig:       bool "Renesas R-Car PCIe controller"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
> 
> We don't have to disallow a driver unbind, since that is already
> done for us in this driver.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
> 
> Cc: Simon Horman <horms@verge.net.au>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci@vger.kernel.org
> Cc: linux-sh@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Acked-by: Simon Horman <horms+renesas@verge.net.au>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 07/10] drivers/pci: make host/pcie-rcar.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-12-13 02:50 +0100
  Re: [PATCH 07/10] drivers/pci: make host/pcie-rcar.c explicitly non-modular Geert Uytterhoeven <geert@linux-m68k.org> - 2015-12-13 12:00 +0100
    Re: [PATCH 07/10] drivers/pci: make host/pcie-rcar.c explicitly  non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-12-13 19:30 +0100
    RE: [PATCH 07/10] drivers/pci: make host/pcie-rcar.c explicitly  non-modular Phil Edworthy <phil.edworthy@renesas.com> - 2015-12-17 12:40 +0100
      Re: [PATCH 07/10] drivers/pci: make host/pcie-rcar.c explicitly  non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-12-17 17:10 +0100
  Re: [PATCH 07/10] drivers/pci: make host/pcie-rcar.c explicitly  non-modular Simon Horman <horms@verge.net.au> - 2015-12-14 06:20 +0100

csiph-web