Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1290795

Re: [PATCH 1/2] ARM: dts: vf-colibri: split PWM pinctrl

Show all headers | View raw

On Wed, Dec 02, 2015 at 02:11:46PM -0800, Stefan Agner wrote:
> Split PWM pins into separate pinctrl nodes to allow overrides which
> select pins individually. This is useful for carrier boards which use
> only one pin for PWM and would like to use the other pin for a
> different purpose.
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>  arch/arm/boot/dts/vf-colibri.dtsi | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/vf-colibri.dtsi b/arch/arm/boot/dts/vf-colibri.dtsi
> index e5949b9..924b660 100644
> --- a/arch/arm/boot/dts/vf-colibri.dtsi
> +++ b/arch/arm/boot/dts/vf-colibri.dtsi
> @@ -74,12 +74,12 @@
>  
>  &pwm0 {
>  	pinctrl-names = "default";
> -	pinctrl-0 = <&pinctrl_pwm0>;
> +	pinctrl-0 = <&pinctrl_pwm0_a &pinctrl_pwm0_c>;
>  };
>  
>  &pwm1 {
>  	pinctrl-names = "default";
> -	pinctrl-0 = <&pinctrl_pwm1>;
> +	pinctrl-0 = <&pinctrl_pwm1_b &pinctrl_pwm1_d>;
>  };

It may make more sense to define these pwm nodes in the final board
level dts with only defining the pins that are actually used on the
board.

Shawn

>  
>  &uart0 {
> @@ -195,16 +195,26 @@
>  			>;
>  		};
>  
> -		pinctrl_pwm0: pwm0grp {
> +		pinctrl_pwm0_a: pwm0agrp {
>  			fsl,pins = <
>  				VF610_PAD_PTB0__FTM0_CH0		0x1182
> +			>;
> +		};
> +
> +		pinctrl_pwm0_c: pwm0cgrp {
> +			fsl,pins = <
>  				VF610_PAD_PTB1__FTM0_CH1		0x1182
>  			>;
>  		};
>  
> -		pinctrl_pwm1: pwm1grp {
> +		pinctrl_pwm1_b: pwm1bgrp {
>  			fsl,pins = <
>  				VF610_PAD_PTB8__FTM1_CH0		0x1182
> +			>;
> +		};
> +
> +		pinctrl_pwm1_d: pwm1dgrp {
> +			fsl,pins = <
>  				VF610_PAD_PTB9__FTM1_CH1		0x1182
>  			>;
>  		};
> -- 
> 2.6.2
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] ARM: dts: vf-colibri: split PWM pinctrl Shawn Guo <shawnguo@kernel.org> - 2015-12-14 03:20 +0100
  Re: [PATCH 1/2] ARM: dts: vf-colibri: split PWM pinctrl Stefan Agner <stefan@agner.ch> - 2015-12-14 04:00 +0100
    Re: [PATCH 1/2] ARM: dts: vf-colibri: split PWM pinctrl Shawn Guo <shawnguo@kernel.org> - 2015-12-21 14:50 +0100

csiph-web