Re: [PATCH 3.16.y-ckt 009/126] sit: fix sit0 percpu double allocations

From	Ben Hutchings <ben@decadent.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3.16.y-ckt 009/126] sit: fix sit0 percpu double allocations
Date	2015-12-13 23:00 +0100
Message-ID	<qFmQq-5ro-1@gated-at.bofh.it> (permalink)
References	(3 earlier) <qFk2f-3De-27@gated-at.bofh.it> <qFlrk-4EA-7@gated-at.bofh.it> <qFlKG-4Mv-3@gated-at.bofh.it> <qFmno-5fC-5@gated-at.bofh.it> <qFmGJ-5no-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sun, 2015-12-13 at 13:44 -0800, Eric Dumazet wrote:
> On Sun, 2015-12-13 at 21:22 +0000, Ben Hutchings wrote:
> > On Sun, 2015-12-13 at 12:43 -0800, Eric Dumazet wrote:
> 
> > > 1) Sorry Ben, I do not understand the problem you mention.
> > >    What is a partially initialized device exactly ?
> > 
> > A tunnel device which is registered but hasn't had its private
> > structure fully initialised yet.
> 
> And you see this happening after my patch ? I am blind.
> 
> I am referring to current linux kernel, not to a backport to pre 3.18
> kernels, that was not considered when I wrote this patch.
> 
> By the time ipip6_fb_tunnel_init() is called, dev->tstats had been
> already allocated in ipip6_tunnel_init(), so what is missing ?

You moved this initialisation below the registration:

> 	ipip6_tunnel_clone_6rd(sitn->fb_tunnel_dev, sitn);
> 	ipip6_fb_tunnel_init(sitn->fb_tunnel_dev);

Ben.

-- 
Ben Hutchings
Life would be so much easier if we could look at the source code.

Thread

Re: [PATCH 3.16.y-ckt 009/126] sit: fix sit0 percpu double  allocations Ben Hutchings <ben@decadent.org.uk> - 2015-12-12 05:20 +0100
  Re: [PATCH 3.16.y-ckt 009/126] sit: fix sit0 percpu double  allocations Luis Henriques <luis.henriques@canonical.com> - 2015-12-13 20:00 +0100
    Re: [PATCH 3.16.y-ckt 009/126] sit: fix sit0 percpu double  allocations Ben Hutchings <ben@decadent.org.uk> - 2015-12-13 21:30 +0100
      Re: [PATCH 3.16.y-ckt 009/126] sit: fix sit0 percpu double  allocations Eric Dumazet <eric.dumazet@gmail.com> - 2015-12-13 21:50 +0100
        Re: [PATCH 3.16.y-ckt 009/126] sit: fix sit0 percpu double  allocations Ben Hutchings <ben@decadent.org.uk> - 2015-12-13 22:30 +0100
          Re: [PATCH 3.16.y-ckt 009/126] sit: fix sit0 percpu double  allocations Eric Dumazet <eric.dumazet@gmail.com> - 2015-12-13 22:50 +0100
            Re: [PATCH 3.16.y-ckt 009/126] sit: fix sit0 percpu double  allocations Ben Hutchings <ben@decadent.org.uk> - 2015-12-13 23:00 +0100
              Re: [PATCH 3.16.y-ckt 009/126] sit: fix sit0 percpu double  allocations Eric Dumazet <eric.dumazet@gmail.com> - 2015-12-13 23:50 +0100
                Re: [PATCH 3.16.y-ckt 009/126] sit: fix sit0 percpu double  allocations Ben Hutchings <ben@decadent.org.uk> - 2015-12-14 00:10 +0100
        Re: [PATCH 3.16.y-ckt 009/126] sit: fix sit0 percpu double  allocations Luis Henriques <luis.henriques@canonical.com> - 2015-12-13 22:40 +0100
        Re: [PATCH 3.16.y-ckt 009/126] sit: fix sit0 percpu double  allocations David Miller <davem@davemloft.net> - 2015-12-13 23:20 +0100
          Re: [PATCH 3.16.y-ckt 009/126] sit: fix sit0 percpu double  allocations Luis Henriques <luis.henriques@canonical.com> - 2015-12-13 23:30 +0100

csiph-web