Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1290684

[PATCH 0/3] block: avoid module usage in non-modular code

Show all headers | View raw

This series of commits is a part of a larger project to ensure
people don't reference modular support functions in non-modular
code.  Overall there was roughly 5k lines of dead code in the
kernel due to this.  So far we've fixed several areas, like tty,
x86, net, ... and we continue to work on other areas.

There are several reasons to not use module support for code that
can never be built as a module, but the big ones are:

 (1) it is easy to accidentally code up unused module_exit and remove code
 (2) it can be misleading when reading the source, thinking it can be
      modular when the Makefile and/or Kconfig prohibit it
 (3) it requires the include of the module.h header file which in turn
     includes nearly everything else.

The block layer is an easy one as far as this cleanup goes.  Only three
files touched, and two of the three don't even change the compiled
objects -- only the noop-iosched had an unused exit function removed.

Cc: Jens Axboe <axboe@kernel.dk>
Cc: Vivek Goyal <vgoyal@redhat.com>

Paul Gortmaker (3):
  block: make genhd.c slightly more explicitly non-modular
  block: make blk-throttle.c explicitly non-modular
  block: make noop-iosched.c explicitly non-modular

 block/blk-throttle.c |  5 ++---
 block/genhd.c        |  2 +-
 block/noop-iosched.c | 19 ++++---------------
 3 files changed, 7 insertions(+), 19 deletions(-)

-- 
2.6.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] block: avoid module usage in non-modular code Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-12-13 21:10 +0100
  [PATCH 1/3] block: make genhd.c slightly more explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-12-13 21:10 +0100

csiph-web