Re: [PATCH 03/10] drivers/pci: make host/pci-mvebu.c explicitly non-modular

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 03/10] drivers/pci: make host/pci-mvebu.c explicitly non-modular
Date	Sun, 13 Dec 2015 11:40:01 +0100
Message-ID	<qFcel-7aI-3@gated-at.bofh.it> (permalink)
References	<qF3Xr-1IU-3@gated-at.bofh.it> <qF3Xs-1IU-11@gated-at.bofh.it>
X-Original-To	Paul Gortmaker <paul.gortmaker@windriver.com>
Organization	Free Electrons
X-Mailer	Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	54
X-Original-Cc	<linux-kernel@vger.kernel.org>, Jason Cooper <jason@lakedaemon.net>, Bjorn Helgaas <bhelgaas@google.com>, <linux-pci@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
X-Original-Date	Sun, 13 Dec 2015 11:33:29 +0100
X-Original-Message-ID	<20151213113329.3b1a303f@free-electrons.com>
X-Original-References	<1449970917-12633-1-git-send-email-paul.gortmaker@windriver.com> <1449970917-12633-4-git-send-email-paul.gortmaker@windriver.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1290602

Show key headers only | View raw

Paul,

On Sat, 12 Dec 2015 20:41:50 -0500, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> drivers/pci/host/Kconfig:config PCI_MVEBU
> drivers/pci/host/Kconfig:       bool "Marvell EBU PCIe controller"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
> 
> We don't have to disallow a driver unbind, since that is already
> done for us in this driver.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now ) contained at the top of the file in the comments.
> 
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>  drivers/pci/host/pci-mvebu.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)

I think the general direction should rather be to change the PCI
subsystem to make it possible for those drivers to be built as modules.
However, since this is quite certainly a much larger effort, there is
no reason to not clean things up as they are today, so:

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 03/10] drivers/pci: make host/pci-mvebu.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-12-13 02:50 +0100
  Re: [PATCH 03/10] drivers/pci: make host/pci-mvebu.c explicitly  non-modular Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-12-13 11:40 +0100
  Re: [PATCH 03/10] drivers/pci: make host/pci-mvebu.c explicitly non-modular Arnd Bergmann <arnd@arndb.de> - 2015-12-14 10:00 +0100

csiph-web