Re: [PATCH] i2c: allow building emev2 without slave mode again

From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] i2c: allow building emev2 without slave mode again
Date	2015-12-13 10:20 +0100
Message-ID	<qFaYV-6rZ-5@gated-at.bofh.it> (permalink)
References	<qEaRj-7yx-3@gated-at.bofh.it> <qEb10-7RF-13@gated-at.bofh.it> <qEVdv-4sK-7@gated-at.bofh.it> <qEZAt-7ul-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

> > > The slave_cb callback function is supposed to set the 'value'
> > > here,
> > 
> > Only if a master wants to READ from us.
> 
> Right, and can this never fail?

Exactly. The slave can stretch the clock if the value to be sent to the
master needs some processing first, but it must deliver something.

> With my current code to turn i2c_slave_event() into an empty inline function
> in case of !CONFIG_I2C_SLAVE, the compiler knows that "value" is uninitialized
> at the point where we write it to the register, and warns about it.

I overlooked that your first patch changed this code, sorry. Now I see
the problem.

What about not ifdeffing the inline function and keep the build error
whenever someone uses it without I2C_SLAVE being selected?

Thanks,

   Wolfram

Thread

Re: [PATCH] i2c: allow building emev2 without slave mode again Wolfram Sang <wsa@the-dreams.de> - 2015-12-12 17:30 +0100
  Re: [PATCH] i2c: allow building emev2 without slave mode again Arnd Bergmann <arnd@arndb.de> - 2015-12-12 22:10 +0100
    Re: [PATCH] i2c: allow building emev2 without slave mode again Wolfram Sang <wsa@the-dreams.de> - 2015-12-13 10:20 +0100
      Re: [PATCH] i2c: allow building emev2 without slave mode again Arnd Bergmann <arnd@arndb.de> - 2015-12-14 13:10 +0100
        Re: [PATCH] i2c: allow building emev2 without slave mode again Wolfram Sang <wsa@the-dreams.de> - 2015-12-14 15:00 +0100
          Re: [PATCH] i2c: allow building emev2 without slave mode again Arnd Bergmann <arnd@arndb.de> - 2015-12-14 23:30 +0100
            Re: [PATCH] i2c: allow building emev2 without slave mode again Wolfram Sang <wsa@the-dreams.de> - 2015-12-17 13:10 +0100
              Re: [PATCH] i2c: allow building emev2 without slave mode again Arnd Bergmann <arnd@arndb.de> - 2015-12-17 15:50 +0100
                Re: [PATCH] i2c: allow building emev2 without slave mode again Wolfram Sang <wsa@the-dreams.de> - 2015-12-17 20:50 +0100
                Re: [PATCH] i2c: allow building emev2 without slave mode again Arnd Bergmann <arnd@arndb.de> - 2015-12-17 21:00 +0100

csiph-web