Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1292193

Re: [PATCH] drivers/misc: make arm-charlcd.c explicitly non-modular

Show all headers | View raw

On Mon, Dec 14, 2015 at 2:07 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:

> The Kconfig currently controlling compilation of this code is:
>
> drivers/misc/Kconfig:config ARM_CHARLCD
> drivers/misc/Kconfig:   bool "ARM Ltd. Character LCD Driver"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> We explicitly disallow a driver unbind, since that doesn't have a
> sensible use case anyway, and this driver did not have a ".remove"
> function coded for non-modular drivers either.
>
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
>
> We don't replace module.h with init.h since the file already has that.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

I would consider the modular code a copy/paste error. Unfortunately
not uncommon in the kernel :(

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Thanks for doing this and keeping the kernel clean.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drivers/misc: make arm-charlcd.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-12-14 02:10 +0100
  Re: [PATCH] drivers/misc: make arm-charlcd.c explicitly non-modular Linus Walleij <linus.walleij@linaro.org> - 2015-12-15 14:50 +0100

csiph-web