Groups > linux.kernel > #1292031

Re: [PATCH 6/6] eeprom: 93xx46: extend driver to plug into the NVMEM framework

From	Andrew Lunn <andrew@lunn.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/6] eeprom: 93xx46: extend driver to plug into the NVMEM framework
Date	2015-12-15 11:40 +0100
Message-ID	<qFVbs-2PM-17@gated-at.bofh.it> (permalink)
References	<qDr7P-3nh-3@gated-at.bofh.it> <qDr7S-3nh-33@gated-at.bofh.it> <qFUIr-2DP-31@gated-at.bofh.it> <qFUS7-2H9-25@gated-at.bofh.it> <qFV1L-2LC-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Dec 15, 2015 at 10:26:47AM +0000, Srinivas Kandagatla wrote:
> + adding Anatolij
> 
> On 15/12/15 10:17, Andrew Lunn wrote:
> >>Is there a reason for this driver to be using the old style?
> >>I can understand the issues with at24/at25 but does this driver also
> >>suffer from such issues?
> >
> >In order to keep backwards compatibility, we need the older file in
> >/sys. The only other option is to remove it and see if anybody
> >complains about us breaking the ABI.
> We should atleast attempt to pitch in this direction, and ask if
> somebody really cares if the location of the eeprom/nvmem file
> matters to them?

I expect it does matter.

This driver does not implement the in kernel API for accessing the
EEPROM. That means all users are in user space. And if this file
moves, it seems very likely these user space users break.

       Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH 6/6] eeprom: 93xx46: extend driver to plug into the NVMEM  framework Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-12-15 11:10 +0100
  Re: [PATCH 6/6] eeprom: 93xx46: extend driver to plug into the NVMEM  framework Andrew Lunn <andrew@lunn.ch> - 2015-12-15 11:20 +0100
    Re: [PATCH 6/6] eeprom: 93xx46: extend driver to plug into the NVMEM  framework Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-12-15 11:30 +0100
      Re: [PATCH 6/6] eeprom: 93xx46: extend driver to plug into the NVMEM  framework Andrew Lunn <andrew@lunn.ch> - 2015-12-15 11:40 +0100
        Re: [PATCH 6/6] eeprom: 93xx46: extend driver to plug into the NVMEM  framework Wolfram Sang <wsa@the-dreams.de> - 2015-12-15 11:50 +0100
        Re: [PATCH 6/6] eeprom: 93xx46: extend driver to plug into the NVMEM  framework Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-12-15 12:00 +0100
      Re: [PATCH 6/6] eeprom: 93xx46: extend driver to plug into the  NVMEM framework Anatolij Gustschin <agust@denx.de> - 2015-12-15 12:10 +0100
        Re: [PATCH 6/6] eeprom: 93xx46: extend driver to plug into the NVMEM  framework Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-12-15 13:30 +0100

csiph-web