Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1292055

Re: [PATCH v2] extcon: add Maxim MAX3355 driver

Show key headers only | View raw

Hello.

On 12/15/2015 2:44 AM, Greg KH wrote:

>>>>>> Maxim  Integrated MAX3355E chip integrates a  charge pump and comparators
>>>>>> to
>>>>>> enable a system with an integrated USB OTG dual-role transceiver to
>>>>>> function
>>>>>> as  an USB  OTG dual-role device.  In addition  to sensing/controlling
>>>>>> Vbus,
>>>>>> the chip also passes thru the ID signal  from the USB  OTG connector.
>>>>>> On some Renesas boards,  this signal is  just fed into the SoC thru a
>>>>>> GPIO
>>>>>> pin --  there's no real  OTG controller, only host and gadget USB
>>>>>> controllers
>>>>>> sharing the same USB bus; however, we'd  like to allow host or gadget
>>>>>> drivers
>>>>>> to be loaded depending on the cable type,  hence the need for the MAX3355
>>>>>> extcon driver. The Vbus status signals are also  wired to GPIOs (however,
>>>>>> we
>>>>>> aren't currently interested in them),  the OFFVBUS# signal is controlled
>>>>>> by
>>>>>> the host controllers, there's  also the SHDN# signal wired to a GPIO, it
>>>>>> should be driven high for the  normal operation.
>>>>>
>>>>>
>>>>> As multiple people have said, fix the spacing here.
>>>>
>>>>
>>>>     You are the first to complain abou _this_ patch. If you don't have other
>>>> issues with this driver in which case you should have trimmed the reply at
>>>> this point), I'd like to keep my spacing as is. Thank you.
>>>
>>> Your previous version was not "extcon-usb-gpio: add enable pin
>>> support"[1] which has now been re-written to be max3355 specific?
>>
>>     No, the MAX3355 driver pre-dates that version. First there was a driver,
>> then I tried to re-use the existing stuff (there was no extcon-usb-gpio at
>> the time of writing my driver), then had to return to the separate driver
>> idea...
>>
>>> "So
>>> what" and "I'd like to keep my spacing as is" aren't valid reasons.
>>> Fix it, then I'll look at the rest again.
>>
>>     I'll consider doing that if you care to explain what's the problem with
>> my spacing. TIA.
>
> You are mixing 2 and 1 spaces between words, don't do that.

    Care to just explain why?

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] extcon: add Maxim MAX3355 driver Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-12 00:30 +0100
  Re: [PATCH v2] extcon: add Maxim MAX3355 driver Rob Herring <robh@kernel.org> - 2015-12-14 02:30 +0100
    Re: [PATCH v2] extcon: add Maxim MAX3355 driver Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-14 18:40 +0100
      Re: [PATCH v2] extcon: add Maxim MAX3355 driver Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-14 23:30 +0100
        Re: [PATCH v2] extcon: add Maxim MAX3355 driver Greg KH <greg@kroah.com> - 2015-12-15 00:50 +0100
          Re: [PATCH v2] extcon: add Maxim MAX3355 driver Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-15 12:30 +0100
            Re: [PATCH v2] extcon: add Maxim MAX3355 driver Geert Uytterhoeven <geert@linux-m68k.org> - 2015-12-15 12:30 +0100
              Re: [PATCH v2] extcon: add Maxim MAX3355 driver Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-15 13:00 +0100
                Re: [PATCH v2] extcon: add Maxim MAX3355 driver Geert Uytterhoeven <geert@linux-m68k.org> - 2015-12-15 13:20 +0100
            Re: [PATCH v2] extcon: add Maxim MAX3355 driver Greg KH <greg@kroah.com> - 2015-12-15 20:00 +0100
              Re: [PATCH v2] extcon: add Maxim MAX3355 driver Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-15 20:10 +0100
      Re: [PATCH v2] extcon: add Maxim MAX3355 driver Rob Herring <robh@kernel.org> - 2015-12-14 23:30 +0100
  Re: [PATCH v2] extcon: add Maxim MAX3355 driver Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-15 02:30 +0100
    Re: [PATCH v2] extcon: add Maxim MAX3355 driver Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-15 20:20 +0100

csiph-web