Re: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver

From	Yong Wu <yong.wu@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver
Date	2015-12-15 03:50 +0100
Message-ID	<qFNQC-6ms-7@gated-at.bofh.it> (permalink)
References	<qDn4e-xE-1@gated-at.bofh.it> <qDndV-AW-25@gated-at.bofh.it> <qFFT6-1gj-61@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2015-12-14 at 19:19 +0100, Matthias Brugger wrote:
> 
> On 08/12/15 10:49, Yong Wu wrote:
> > This patch adds support for mediatek m4u (MultiMedia Memory Management
> > Unit).
> >
> > Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> > ---
[...]
> > +static void mtk_iommu_config(struct mtk_iommu_data *data,
> > +			     struct device *dev, bool enable)
> > +{
> > +	struct mtk_iommu_client_priv *head, *cur, *next;
> > +
> > +	head = dev->archdata.iommu;
> > +	list_for_each_entry_safe(cur, next, &head->client, client) {
> > +		mtk_smi_config_port(
> > +			data->larbdev[MTK_M4U_TO_LARB(cur->mtk_m4u_id)],
> > +			MTK_M4U_TO_PORT(cur->mtk_m4u_id), enable);
> 
> Use an extra variable for MTK_M4U_TO_LARB(cur->mtk-m4u_id), this makes 
> the code easier to read.

OK. Thanks.
I will fix it in next version.

> 
> Regards,
> Matthias
> 
> > +	}
> > +}
> > +
[...]


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver Matthias Brugger <matthias.bgg@gmail.com> - 2015-12-14 19:20 +0100
  Re: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver Yong Wu <yong.wu@mediatek.com> - 2015-12-15 03:50 +0100

csiph-web