Re: [RFC] powerpc: Enable UBSAN support

Path	csiph.com!goblin2!goblin.stu.neva.ru!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [RFC] powerpc: Enable UBSAN support
Date	Tue, 15 Dec 2015 03:50:01 +0100
Message-ID	<qFNQB-6ms-1@gated-at.bofh.it> (permalink)
References	<qDXAK-7eK-5@gated-at.bofh.it>
X-Original-To	Daniel Axtens <dja@axtens.net>, linuxppc-dev@ozlabs.org
X-Ibm-Helo	d23dlp03.au.ibm.com
X-Ibm-Mailfrom	andrew.donnellan@au1.ibm.com
X-Ibm-Rcptto	linux-kernel@vger.kernel.org
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.4.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding	7bit
X-Tm-As-Mml	disable
X-Content-Scanned	Fidelis XPS MAILER
X-Cbid	15121502-1618-0000-0000-0000034B58A8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	43
Organization	linux.* mail to news gateway
X-Original-Cc	akpm@linux-foundation.org, Andrey Ryabinin <aryabinin@virtuozzo.com>, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 15 Dec 2015 13:40:26 +1100
X-Original-Message-ID	<566F7D9A.4050806@au1.ibm.com>
X-Original-References	<1449708123-7340-1-git-send-email-dja@axtens.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1291798

Show key headers only | View raw

On 10/12/15 11:42, Daniel Axtens wrote:
> This hooks up UBSAN support for PowerPC.
>
> So far it's found some interesting cases where we don't properly sanitise
> input to shifts, including one in our futex handling. Nothing critical,
> but interesting and worth fixing.
>
> CC: Andrey Ryabinin <aryabinin@virtuozzo.com>
> ---
>
> This to be applied on top of next with Andrey's patches:
>   1) https://patchwork.kernel.org/patch/7761341/
>   2) https://patchwork.kernel.org/patch/7761351/
>   3) https://patchwork.kernel.org/patch/7761361/
>   4) https://patchwork.kernel.org/patch/7785791/
>
> This is RFC for a couple of reasons:
>
>   - I'd like the original patches to
>     s/ARCH_HAS_UBSAN_SANTIZE_ALL/ARCH_HAS_UBSAN_SAN*I*TIZE_ALL/
>     (I'm about to send an email about that)
>
>   - I've only tested on LE pseries so far - I want to test on powernv,
>     and on BE.
>
> Signed-off-by: Daniel Axtens <dja@axtens.net>

I tested this patch as found in linux-next, along with the SANITIZE_ALL 
typo fix, on a big-endian BML system, with gcc 5.2.1. It successfully 
picked up one of the shift input issues that Daniel found, so therefore...

Tested-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>

-- 
Andrew Donnellan              Software Engineer, OzLabs
andrew.donnellan@au1.ibm.com  Australia Development Lab, Canberra
+61 2 6201 8874 (work)        IBM Australia Limited

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [RFC] powerpc: Enable UBSAN support Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2015-12-15 03:50 +0100

csiph-web