Re: [RFC PATCH 2/2] block: virtio-blk: support multi virt queues per virtio-blk device

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Ming Lei <ming.lei@canonical.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 2/2] block: virtio-blk: support multi virt queues per virtio-blk device
Date	Tue, 15 Dec 2015 02:30:02 +0100
Message-ID	<qFMBc-5DF-11@gated-at.bofh.it> (permalink)
References	<nsDCi-4de-3@gated-at.bofh.it> <nsDCi-4de-1@gated-at.bofh.it> <ntRDc-1CH-3@gated-at.bofh.it> <nu3XI-38e-3@gated-at.bofh.it> <nu3XK-38e-51@gated-at.bofh.it> <nu47o-3zk-5@gated-at.bofh.it> <nu4As-49m-55@gated-at.bofh.it> <nufma-3yJ-3@gated-at.bofh.it> <qFyHV-4U5-53@gated-at.bofh.it>
X-Original-To	Paolo Bonzini <pbonzini@redhat.com>
MIME-Version	1.0
X-Received	by 10.28.171.135 with SMTP id u129mr1113593wme.99.1450142805044; Mon, 14 Dec 2015 17:26:45 -0800 (PST)
X-Gmail-Original-Message-ID	<CACVXFVMe-BB_S=doiZm0XYezzrYX_E4gc8_85N4BA=g5y8fAWw@mail.gmail.com>
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	43
Organization	linux.* mail to news gateway
X-Original-Cc	Jens Axboe <axboe@kernel.dk>, "Michael S. Tsirkin" <mst@redhat.com>, linux-kernel <linux-kernel@vger.kernel.org>, Linux Virtualization <virtualization@lists.linux-foundation.org>, Stefan Hajnoczi <stefanha@redhat.com>, linux-api@vger.kernel.org
X-Original-Date	Tue, 15 Dec 2015 09:26:44 +0800
X-Original-Message-ID	<CACVXFVMe-BB_S=doiZm0XYezzrYX_E4gc8_85N4BA=g5y8fAWw@mail.gmail.com>
X-Original-References	<1402680562-8328-1-git-send-email-ming.lei@canonical.com> <1402680562-8328-3-git-send-email-ming.lei@canonical.com> <CAJSP0QWaS--gPZ=ONFrXby1DQLw4R0RCro7bpHCdmucyjmqT_w@mail.gmail.com> <CACVXFVO0SybUKArQbKkj2+hbk6q_gt3SBooNNmw1jErRR8d07A@mail.gmail.com> <53A06475.7000308@redhat.com> <CACVXFVO6GDu7Cp=s7kn_XBE2EFnuh+XQs4UQKTFaCLi4_9jcgg@mail.gmail.com> <53A06E05.9060708@redhat.com> <CACVXFVMkV5R5GUjM7Y-U54SA-ENZZ26dbbv4K2_OYPdmmiuUqg@mail.gmail.com> <566E9A7E.3030203@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1291747

Show key headers only | View raw

Hi Paolo,

On Mon, Dec 14, 2015 at 6:31 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
> On 18/06/2014 06:04, Ming Lei wrote:
>> For virtio-blk, I don't think it is always better to take more queues, and
>> we need to leverage below things in host side:
>>
>> - host storage top performance, generally it reaches that with more
>> than 1 jobs with libaio(suppose it is N, so basically we can use N
>> iothread per device in qemu to try to get top performance)
>>
>> - iothreads' loading(if iothreads are at full loading, increasing
>> queues doesn't help at all)
>>
>> In my test, I only use the current per-dev iothread(x-dataplane)
>> in qemu to handle 2 vqs' notification and precess all I/O from
>> the 2 vqs, and looks it can improve IOPS by ~30%.
>>
>> For virtio-scsi, the current usage doesn't make full use of blk-mq's
>> advantage too because only one vq is active at the same time, so I
>> guess the multi vqs' benefit won't be very much and I'd like to post
>> patches to support that first, then provide test data with
>> more queues(8, 16).
>
> Hi Ming Lei,
>
> would you like to repost these patches now that MQ support is in the kernel?
>
> Also, I changed my mind about moving linux-aio to AioContext.  I now
> think it's a good idea, because it limits the number of io_getevents
> syscalls. O:-)  So I would be happy to review your patches for that as well.

OK, I try to figure out a new version, and it might take a while since it is
close to festival season, :-)

Thanks,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH 2/2] block: virtio-blk: support multi virt queues per  virtio-blk device Paolo Bonzini <pbonzini@redhat.com> - 2015-12-14 11:40 +0100
  Re: [RFC PATCH 2/2] block: virtio-blk: support multi virt queues per  virtio-blk device Ming Lei <ming.lei@canonical.com> - 2015-12-15 02:30 +0100

csiph-web