Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1291632

Re: [POWERPC] bootwrapper: One check less in fsl_get_immr() after error detection

Show all headers | View raw

On Mon, 2015-12-14 at 23:10 +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 14 Dec 2015 23:01:32 +0100
> 
> A status check was performed by the fsl_get_immr() function even if it
> was known already that a system setting did not fit to the expectations.
> 
> This implementation detail could be improved by an adjustment for
> a jump label according to the Linux coding style convention.

What is the actual problem you're trying to solve?  Cluttering the code to
micro-optimize an error path is not an improvement.

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[POWERPC] bootwrapper: One check less in fsl_get_immr() after error  detection SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-14 23:20 +0100
  Re: [POWERPC] bootwrapper: One check less in fsl_get_immr() after  error detection Scott Wood <scottwood@freescale.com> - 2015-12-14 23:40 +0100

csiph-web