Re: [PATCH v6 4/4] x86: mm: support ARCH_MMAP_RND_BITS.

From	Daniel Cashman <dcashman@android.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 4/4] x86: mm: support ARCH_MMAP_RND_BITS.
Date	2015-12-14 22:00 +0100
Message-ID	<qFInT-2LW-1@gated-at.bofh.it> (permalink)
References	(1 earlier) <qEA93-7FL-7@gated-at.bofh.it> <qEA94-7FL-21@gated-at.bofh.it> <qEA94-7FL-23@gated-at.bofh.it> <qEA94-7FL-19@gated-at.bofh.it> <qFGFt-1Ro-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 12/14/2015 10:58 AM, H. Peter Anvin wrote:
> On 12/11/15 09:52, Daniel Cashman wrote:
>> diff --git a/arch/x86/mm/mmap.c b/arch/x86/mm/mmap.c
>> index 844b06d..647fecf 100644
>> --- a/arch/x86/mm/mmap.c
>> +++ b/arch/x86/mm/mmap.c
>> @@ -69,14 +69,14 @@ unsigned long arch_mmap_rnd(void)
>>  {
>>  	unsigned long rnd;
>>  
>> -	/*
>> -	 *  8 bits of randomness in 32bit mmaps, 20 address space bits
>> -	 * 28 bits of randomness in 64bit mmaps, 40 address space bits
>> -	 */
>>  	if (mmap_is_ia32())
>> -		rnd = (unsigned long)get_random_int() % (1<<8);
>> +#ifdef CONFIG_COMPAT
>> +		rnd = (unsigned long)get_random_int() % (1 << mmap_rnd_compat_bits);
>> +#else
>> +		rnd = (unsigned long)get_random_int() % (1 << mmap_rnd_bits);
>> +#endif
>>  	else
>> -		rnd = (unsigned long)get_random_int() % (1<<28);
>> +		rnd = (unsigned long)get_random_int() % (1 << mmap_rnd_bits);
>>  
>>  	return rnd << PAGE_SHIFT;
>>  }
>>
> 
> Now, you and I know that both variants can be implemented with a simple
> AND, but I have a strong suspicion that once this is turned into a
> variable, this will in fact be changed from an AND to a divide.
> 
> So I'd prefer to use the
> "get_random_int() & ((1UL << mmap_rnd_bits) - 1)" construct instead.

Good point.  Will change in v7 across patch-set.

Thank You,
Dan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6 4/4] x86: mm: support ARCH_MMAP_RND_BITS. "H. Peter Anvin" <hpa@zytor.com> - 2015-12-14 20:10 +0100
  Re: [PATCH v6 4/4] x86: mm: support ARCH_MMAP_RND_BITS. Daniel Cashman <dcashman@android.com> - 2015-12-14 22:00 +0100

csiph-web