Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1291575

Re: [PATCH 0/3] cpuidle: avoid module usage in non-modular code

Show all headers | View raw

On 12/14/2015 12:57 AM, Paul Gortmaker wrote:
> This series of commits is a part of a larger project to ensure
> people don't reference modular support functions in non-modular
> code.  Overall there was roughly 5k lines of dead code in the
> kernel due to this.  So far we've fixed several areas, like tty,
> x86, net, ... and we continue to work on other areas.
>
> There are several reasons to not use module support for code that
> can never be built as a module, but the big ones are:
>
>   (1) it is easy to accidentally code up unused module_exit and remove code
>   (2) it can be misleading when reading the source, thinking it can be
>        modular when the Makefile and/or Kconfig prohibit it
>   (3) it requires the include of the module.h header file which in turn
>       includes nearly everything else.
>
> Fortunately for cpuidle, the changes are largely trivial and change
> zero runtime.  All the changes here just remap the modular functions
> onto the non-modular ones that they would be remapped onto anyway.
>
> Changes are against linux-next and compile tested on ARM allmodconfig.
> I've Cc'd ARM list because all of these are used on ARM, but I'm
> thinking these probably can go in via the PM tree.

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] cpuidle: avoid module usage in non-modular code Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-12-14 01:00 +0100
  [PATCH 1/3] drivers/cpuidle: make cpuidle-clps711x.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-12-14 01:00 +0100
  [PATCH 3/3] drivers/cpuidle: make cpuidle-exynos.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-12-14 01:10 +0100
  Re: [PATCH 0/3] cpuidle: avoid module usage in non-modular code "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-12-14 22:10 +0100
    Re: [PATCH 0/3] cpuidle: avoid module usage in non-modular code Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-12-14 22:40 +0100
  Re: [PATCH 0/3] cpuidle: avoid module usage in non-modular code Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-12-14 22:20 +0100

csiph-web