Re: [PATCH] kbuild: support make dir/file.i for *.S

Path	csiph.com!au2pb.net!2.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Wang YanQing <udknight@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] kbuild: support make dir/file.i for *.S
Date	Mon, 14 Dec 2015 18:20:02 +0100
Message-ID	<qFEX0-DM-17@gated-at.bofh.it> (permalink)
References	<qEcq6-cf-5@gated-at.bofh.it> <qEXS2-6dM-21@gated-at.bofh.it>
X-Original-To	Brian Gerst <brgerst@gmail.com>, mmarek@suse.com
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=BwMcQPxxsDglQzFTQMbCAyUoXJzpDtJcpphVQiUtcoM=; b=rPw+vzmq0hiPuZ/QL7wM5T/Vsp7YxKG9gAUM/sGp/cHdWUh/L6aqPFk+R2xBeJ+w9I XKBmqWD5OE/V3Ia3cXip077rJ19aMA/hQ7nJZHYRzEfFEt2zkNfH7DgjbXu33h4f+1qv 41qSJUSszEFBiImRjbI2zTA1Kz1lgyTPMRBxNFKiZKwPCQUsqQ6tIATcp4Olo27O85K1 r1AbaCIbzi5x4knr5AVet5I9s8kVmjJzjwOdJ9MnbPTj09gG6fsJjmV98IOoBdggMie3 TMmkBteVZGEZxSflNxh5a5XtKdT2BvuWjlQQtuhgLGyQuzLLcChiSMfr4HNfDLi2jP8A 0mGw==
X-Received	by 10.66.155.197 with SMTP id vy5mr47480170pab.109.1450113145501; Mon, 14 Dec 2015 09:12:25 -0800 (PST)
Mail-Followup-To	Wang YanQing <udknight@gmail.com>, Brian Gerst <brgerst@gmail.com>, mmarek@suse.com, linux-kbuild@vger.kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, yamada.masahiro@socionext.com
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.22 (2013-10-16)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	53
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kbuild@vger.kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, yamada.masahiro@socionext.com
X-Original-Date	Tue, 15 Dec 2015 00:14:01 +0800
X-Original-Message-ID	<20151214161401.GA8036@udknight>
X-Original-References	<20151210163329.GA18947@udknight> <CAMzpN2jG+mKQdAxKnvTebQtF1J79pC+E4QxELLO_C2K6ZR8PzA@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1291359

Show key headers only | View raw

On Sat, Dec 12, 2015 at 02:13:03PM -0500, Brian Gerst wrote:
> On Thu, Dec 10, 2015 at 11:33 AM, Wang YanQing <udknight@gmail.com> wrote:
> > This feature could reduce a little time to expand all
> > the macros in *.S for reading.
> >
> > Signed-off-by: Wang YanQing <udknight@gmail.com>
> > ---
> >  Makefile               | 2 ++
> >  scripts/Makefile.build | 6 ++++++
> >  2 files changed, 8 insertions(+)
> >
> > diff --git a/Makefile b/Makefile
> > index 7558c9c..d7e2060 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1552,6 +1552,8 @@ endif
> >         $(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)
> >  %.s: %.S prepare scripts FORCE
> >         $(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)
> > +%.i: %.S prepare scripts FORCE
> > +       $(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)
> >  %.o: %.S prepare scripts FORCE
> >         $(Q)$(MAKE) $(build)=$(build-dir) $(target-dir)$(notdir $@)
> >  %.symtypes: %.c prepare scripts FORCE
> > diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> > index 2c47f9c..2a51d49 100644
> > --- a/scripts/Makefile.build
> > +++ b/scripts/Makefile.build
> > @@ -287,6 +287,12 @@ cmd_as_s_S       = $(CPP) $(a_flags)   -o $@ $<
> >  $(obj)/%.s: $(src)/%.S FORCE
> >         $(call if_changed_dep,as_s_S)
> >
> > +quiet_cmd_cc_i_S = CPP $(quiet_modtag) $@
> > +cmd_cc_i_S       = $(CPP) $(a_flags)   -o $@ $<
> > +
> > +$(obj)/%.i: $(src)/%.S FORCE
> > +       $(call if_changed_dep,cc_i_S)
> > +
> >  quiet_cmd_as_o_S = AS $(quiet_modtag)  $@
> >  cmd_as_o_S       = $(CC) $(a_flags) -c -o $@ $<
> 
> *.s (lower case) is the suffix used for preprocessed assembly files,
> and there is already a rule for that.  *.i is for preprocessed C
> files.

Agreed, you are right!

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] kbuild: support make dir/file.i for *.S Brian Gerst <brgerst@gmail.com> - 2015-12-12 20:20 +0100
  Re: [PATCH] kbuild: support make dir/file.i for *.S Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-12-13 09:20 +0100
  Re: [PATCH] kbuild: support make dir/file.i for *.S Wang YanQing <udknight@gmail.com> - 2015-12-14 18:20 +0100
    Re: [PATCH] kbuild: support make dir/file.i for *.S Michal Marek <mmarek@suse.com> - 2015-12-14 18:20 +0100
      Re: [PATCH] kbuild: support make dir/file.i for *.S Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-12-15 02:50 +0100

csiph-web