Re: [PATCHSET 00/16] perf top: Add multi-thread support (v1)

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Namhyung Kim <namhyung@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCHSET 00/16] perf top: Add multi-thread support (v1)
Date	Mon, 14 Dec 2015 18:20:02 +0100
Message-ID	<qFEX0-DM-13@gated-at.bofh.it> (permalink)
References	<qE4iS-39l-7@gated-at.bofh.it> <qE4sy-3sW-9@gated-at.bofh.it> <qE55f-3L0-3@gated-at.bofh.it> <qEr5L-1BY-11@gated-at.bofh.it> <qExuy-69x-11@gated-at.bofh.it> <qFxCa-4ar-15@gated-at.bofh.it> <qFxLP-4dP-17@gated-at.bofh.it> <qFEki-9n-21@gated-at.bofh.it> <qFEDE-gS-7@gated-at.bofh.it>
X-Original-To	Peter Zijlstra <peterz@infradead.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=T5xPyiv0RjmadkIj5jFNo2C2u6XjvG1mNNQ194z+w6g=; b=ioXJbt6HDsi5JmqdKhLJ6FqOIzfgTJxwnCQBIy4cBhddb7ThPynSYwfbtqTjj8/7gS c6wARMiHK4RMiGXTrql0ZyrNpv6pE0gzqYziHuimbXNQqTu4NvDtWapP4KeYP1Hh30dV sHxgwuGMXJ9zftou1VQ7ycv3NvhpvPKv3NMkpTHDS1mntQHSy3HW9VYSjduQKfwNxwbE fRb5xq0mlK/WYEShStoWSDoA9OfhJDxkTrmm2hTY8VxUjDuEn7TrqkTGNiq6yej1SYKb dh8ykM/8lxkg8oXiohAotCf15cngu3z2q5nzvIzzfZJIkdmSiXz8B12MsWBL9O7yiIg9 5BCQ==
X-Received	by 10.66.119.136 with SMTP id ku8mr48071649pab.128.1450113144557; Mon, 14 Dec 2015 09:12:24 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	Ingo Molnar <mingo@kernel.org>, David Ahern <dsahern@gmail.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>, Frederic Weisbecker <fweisbec@gmail.com>, Andi Kleen <andi@firstfloor.org>, Stephane Eranian <eranian@google.com>, Adrian Hunter <adrian.hunter@intel.com>
X-Original-Date	Tue, 15 Dec 2015 02:11:43 +0900
X-Original-Message-ID	<20151214171143.GD23614@danjae.kornet>
X-Original-References	<1449734015-9148-1-git-send-email-namhyung@kernel.org> <20151210080118.GA8664@gmail.com> <5E6F0F13-9696-45F1-A0E8-CA0B95020D10@gmail.com> <20151211081141.GA21600@gmail.com> <566AE54B.1010702@gmail.com> <20151214092613.GL6357@twins.programming.kicks-ass.net> <20151214093841.GB30347@gmail.com> <20151214163830.GB23614@danjae.kornet> <20151214165614.GV6357@twins.programming.kicks-ass.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1291360

Show key headers only | View raw

On Mon, Dec 14, 2015 at 05:56:14PM +0100, Peter Zijlstra wrote:
> On Tue, Dec 15, 2015 at 01:38:30AM +0900, Namhyung Kim wrote:
> > It requires many changes, but basically I also like the split-up since
> > it's easier to deal with.  IIRC there was an opinion (Andi?) regarding
> > single-file vs multi-file.  The file access will be better for single
> > file so I changed my earlier implementation to use indexed single data
> > file instead of multiple files.
> 
> The page-cache has a lock per inode, so by having all CPUs populate the
> one file you get contention on that.
> 
> Also, I suppose you'll have to arbitrate ranges in that file for each
> cpu to make it work, that too could get you some contention.
> 
> Having a file per cpu avoids all that.

Right.  Now I recall that it was about *report* (not record) time
accessing single file vs. multi files.

At record time we should use file per cpu.  I combined them into
one with index at post-processing time in my earlier work.

Thanks for clarification!
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCHSET 00/16] perf top: Add multi-thread support (v1) Peter Zijlstra <peterz@infradead.org> - 2015-12-14 10:30 +0100
  Re: [PATCHSET 00/16] perf top: Add multi-thread support (v1) Ingo Molnar <mingo@kernel.org> - 2015-12-14 10:40 +0100
    Re: [PATCHSET 00/16] perf top: Add multi-thread support (v1) David Ahern <dsahern@gmail.com> - 2015-12-14 16:00 +0100
      Re: [PATCHSET 00/16] perf top: Add multi-thread support (v1) Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-12-14 17:30 +0100
        Re: [PATCHSET 00/16] perf top: Add multi-thread support (v1) Peter Zijlstra <peterz@infradead.org> - 2015-12-14 17:50 +0100
          Re: [PATCHSET 00/16] perf top: Add multi-thread support (v1) Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-12-14 19:00 +0100
    Re: [PATCHSET 00/16] perf top: Add multi-thread support (v1) Namhyung Kim <namhyung@kernel.org> - 2015-12-14 17:40 +0100
      Re: [PATCHSET 00/16] perf top: Add multi-thread support (v1) Peter Zijlstra <peterz@infradead.org> - 2015-12-14 18:00 +0100
        Re: [PATCHSET 00/16] perf top: Add multi-thread support (v1) Namhyung Kim <namhyung@kernel.org> - 2015-12-14 18:20 +0100
  Re: [PATCHSET 00/16] perf top: Add multi-thread support (v1) David Ahern <dsahern@gmail.com> - 2015-12-14 15:50 +0100
    Re: [PATCHSET 00/16] perf top: Add multi-thread support (v1) Namhyung Kim <namhyung@kernel.org> - 2015-12-14 18:10 +0100
      Re: [PATCHSET 00/16] perf top: Add multi-thread support (v1) Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-12-14 19:00 +0100
  Re: [PATCHSET 00/16] perf top: Add multi-thread support (v1) Namhyung Kim <namhyung@kernel.org> - 2015-12-14 17:30 +0100
    Re: [PATCHSET 00/16] perf top: Add multi-thread support (v1) Peter Zijlstra <peterz@infradead.org> - 2015-12-14 17:50 +0100

csiph-web