Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1291354

Re: [PATCH] ARM64: ZynqMP: DT: Fix GIC's 'reg' property

Show all headers | View raw

Mark,

On 14/12/15 16:46, Mark Rutland wrote:
> On Mon, Dec 14, 2015 at 08:31:40AM -0800, Soren Brinkmann wrote:
>> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
>> ---
>>  arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> index 857eda5c7217..b5d1facadf16 100644
>> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> @@ -80,10 +80,10 @@
>>  		gic: interrupt-controller@f9010000 {
>>  			compatible = "arm,gic-400", "arm,cortex-a15-gic";
>>  			#interrupt-cells = <3>;
>> -			reg = <0x0 0xf9010000 0x10000>,
>> -			      <0x0 0xf902f000 0x2000>,
>> +			reg = <0x0 0xf9010000 0x1000>,
>> +			      <0x0 0xf9020000 0x20000>,
>>  			      <0x0 0xf9040000 0x20000>,
>> -			      <0x0 0xf906f000 0x2000>;
>> +			      <0x0 0xf9060000 0x20000>;
> 
> I'm confused. These sizes don't look right for GIC-400. Is this a custom
> GIC?

Probably an implementation that obey the SBSA requirement of aliasing
the first 4kB of the CPU interface on a 64kB page, and the second one on
the following 64kB page. See the APM system for an example of such a
thing. I'm more concerned about the GICH region (3rd one), which has no
reason to be bigger than 4kB.

> Did this ever work wit hteh old offsets and sizes?

It probably dies when trying to use EOImode==1.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARM64: ZynqMP: DT: Fix GIC's 'reg' property Soren Brinkmann <soren.brinkmann@xilinx.com> - 2015-12-14 17:40 +0100
  Re: [PATCH] ARM64: ZynqMP: DT: Fix GIC's 'reg' property Mark Rutland <mark.rutland@arm.com> - 2015-12-14 17:50 +0100
    Re: [PATCH] ARM64: ZynqMP: DT: Fix GIC's 'reg' property Marc Zyngier <marc.zyngier@arm.com> - 2015-12-14 18:10 +0100
      Re: [PATCH] ARM64: ZynqMP: DT: Fix GIC's 'reg' property Sören Brinkmann <soren.brinkmann@xilinx.com> - 2015-12-15 10:20 +0100
        Re: [PATCH] ARM64: ZynqMP: DT: Fix GIC's 'reg' property Michal Simek <michal.simek@xilinx.com> - 2015-12-15 16:10 +0100
          Re: [PATCH] ARM64: ZynqMP: DT: Fix GIC's 'reg' property Sören Brinkmann <soren.brinkmann@xilinx.com> - 2015-12-16 10:00 +0100
            Re: [PATCH] ARM64: ZynqMP: DT: Fix GIC's 'reg' property Marc Zyngier <marc.zyngier@arm.com> - 2015-12-16 10:10 +0100

csiph-web