Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1291273
| From | "Marciniszyn, Mike" <mike.marciniszyn@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH 2/3] staging/rdma/hfi1: check return value of kcalloc |
| Date | 2015-12-14 16:30 +0100 |
| Message-ID | <qFDex-7Vd-1@gated-at.bofh.it> (permalink) |
| References | <ds889-8u2-7@gated-at.bofh.it> <qFCLw-7vq-9@gated-at.bofh.it> <qFCLw-7vq-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> @@ -10129,6 +10129,9 @@ static void init_qos(struct hfi1_devdata *dd, > u32 first_ctxt) > if (num_vls * qpns_per_vl > dd->chip_rcv_contexts) > goto bail; > rsmmap = kcalloc(NUM_MAP_REGS, sizeof(u64), GFP_KERNEL); > + if (!rsmmap) > + goto bail; > + I checked out a linux-next remote at the next-20151214 tag. The allocation method is clearly kmalloc_array() not kcalloc(). Where are you seeing the kcalloc()? While it is tempting to allocate and zero, there is a chip rev specific difference. Mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/3] staging/rdma/hfi1: check return value of kcalloc Nicholas Mc Guire <hofrat@osadl.org> - 2015-12-14 16:00 +0100
RE: [PATCH 2/3] staging/rdma/hfi1: check return value of kcalloc "Marciniszyn, Mike" <mike.marciniszyn@intel.com> - 2015-12-14 16:30 +0100
Re: [PATCH 2/3] staging/rdma/hfi1: check return value of kcalloc Nicholas Mc Guire <der.herr@hofr.at> - 2015-12-14 18:40 +0100
csiph-web