Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1291256

Re: [RFC 1/2] [RFC] mm: Account anon mappings as RLIMIT_DATA

Show all headers | View raw

On Mon, Dec 14, 2015 at 03:51:26PM +0100, Quentin Casasnovas wrote:
...
> 
> Do we want to fold may_expand_anon_vm() into may_expand_vm() (potentially
> passing it the flags/struct file if needed) so there is just one such
> helper function?  Rationale being that it then gets hard to see what
> restricts what, and it's easy to miss one place.

I tried to make the patch small as possible (because otherwise indeed
I would have to pass @vm_file|@file as additional argument). This won't
be a problem but may_expand_vm is called way more times than
may_expand_anon_vm. That's the only rationale I followed.

> For example, I couldn't find anything preventing a user to
> mmap(MAP_GROWSDOWN) and uses that as a base to get pages that would not be
> accounted for in your patch (making it a poor-man mremap()).

growsup/down stand for stack usage iirc, so it was intentionally
not accounted here.

> 
> I only had a quick look so apologies if this is handled and I missed it :)

thanks for feedback! also take a look on Kostya's patch, I think it's
even better approach (and I like it more than mine).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC 1/2] [RFC] mm: Account anon mappings as RLIMIT_DATA Cyrill Gorcunov <gorcunov@gmail.com> - 2015-12-13 21:20 +0100
  Re: [RFC 1/2] [RFC] mm: Account anon mappings as RLIMIT_DATA Konstantin Khlebnikov <koct9i@gmail.com> - 2015-12-14 09:20 +0100
    [PATCH RFC] mm: rework virtual memory accounting Konstantin Khlebnikov <koct9i@gmail.com> - 2015-12-14 09:20 +0100
      Re: [PATCH RFC] mm: rework virtual memory accounting Cyrill Gorcunov <gorcunov@gmail.com> - 2015-12-14 10:10 +0100
  Re: [RFC 1/2] [RFC] mm: Account anon mappings as RLIMIT_DATA Quentin Casasnovas <quentin.casasnovas@oracle.com> - 2015-12-14 16:00 +0100
    Re: [RFC 1/2] [RFC] mm: Account anon mappings as RLIMIT_DATA Cyrill Gorcunov <gorcunov@gmail.com> - 2015-12-14 16:20 +0100
      Re: [RFC 1/2] [RFC] mm: Account anon mappings as RLIMIT_DATA Quentin Casasnovas <quentin.casasnovas@oracle.com> - 2015-12-14 16:40 +0100
        Re: [RFC 1/2] [RFC] mm: Account anon mappings as RLIMIT_DATA Cyrill Gorcunov <gorcunov@gmail.com> - 2015-12-14 16:50 +0100

csiph-web