Re: [Patch v5 1/2] media: v4l: ti-vpe: Add CAL v4l2 camera capture driver

From	Hans Verkuil <hverkuil@xs4all.nl>
Newsgroups	linux.kernel
Subject	Re: [Patch v5 1/2] media: v4l: ti-vpe: Add CAL v4l2 camera capture driver
Date	2015-12-14 15:50 +0100
Message-ID	<qFCBQ-7sa-7@gated-at.bofh.it> (permalink)
References	<qwhPY-84P-9@gated-at.bofh.it> <qwhPZ-84P-27@gated-at.bofh.it> <qBBXH-5yd-21@gated-at.bofh.it> <qEEcG-1XA-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 12/11/2015 11:16 PM, Benoit Parrot wrote:
> Mauro Carvalho Chehab <mchehab@osg.samsung.com> wrote on Thu [2015-Dec-03 11:19:22 -0200]:
>>> +static int cal_enum_framesizes(struct file *file, void *fh,
>>> +			       struct v4l2_frmsizeenum *fsize)
>>> +{
>>> +	struct cal_ctx *ctx = video_drvdata(file);
>>> +	const struct cal_fmt *fmt;
>>> +	struct v4l2_subdev_frame_size_enum fse;
>>> +	int ret;
>>> +
>>> +	ctx_dbg(2, ctx, "%s\n", __func__);
>>
>> This s a general note: do you really need tracing-like debug macros
>> all around the code?
>>
>> You could easily check if the functions are called via trace.
> 
> True but that also mean to rebuild the kernel in order to
> get to it since function tracing is usually not enabled
> by default.
> 

You can enable debugging by doing:

echo 2 >/sys/class/video4linux/video0/dev_debug

See also: Documentation/video4linux/v4l2-framework.txt, section "video device
debugging" for more info.

That's always available and basically does what you want.

Regards,

	Hans

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [Patch v5 1/2] media: v4l: ti-vpe: Add CAL v4l2 camera capture  driver Hans Verkuil <hverkuil@xs4all.nl> - 2015-12-14 15:50 +0100

csiph-web