Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1291181

[LINUX RFC v3 1/4] spi: addng support for data stripe feature in core

Show all headers | View raw

This patch enables data stripe feature in spi core. This feature is
required to support dual parallel mode of ZynqMP GQSPI controller.

To achieve the same an API SPI_MASTER_DATA_STRIPE is added.
With data stripe enabled,
  - even bytes i.e. 0, 2, 4,... are transmitted on lower data bus
  - odd bytes i.e. 1, 3, 5,.. are transmitted on upper data bus.

To support data stripe; need to  assert both chip selects once.
This is achieved throught API SPI_MASTER_BOTH_CS.

Signed-off-by: Ranjit Waghmode <ranjit.waghmode@xilinx.com>

---
V3 Changes:
	- Updated comments for newly added APIs.
	- Changed patch description for ease of understanding
V2 Changes:
	- Added error handling condition for newly added features
---

 drivers/spi/spi.c       |  8 ++++++++
 include/linux/spi/spi.h | 11 +++++++++++
 2 files changed, 19 insertions(+)

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 2b0a8ec..930dac3 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -2106,6 +2106,14 @@ static int __spi_validate(struct spi_device *spi, struct spi_message *message)
 	if (list_empty(&message->transfers))
 		return -EINVAL;

+	/*
+	 * Data stripe option is selected if and only if when
+	 * two chips are enabled
+	 */
+	if ((master->flags & SPI_MASTER_DATA_STRIPE)
+		&& !(master->flags & SPI_MASTER_BOTH_CS))
+			return -EINVAL;
+
 	/* Half-duplex links include original MicroWire, and ones with
 	 * only one data pin like SPI_3WIRE (switches direction) or where
 	 * either MOSI or MISO is missing.  They can also be caused by
diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h
index cce80e6..e83b667 100644
--- a/include/linux/spi/spi.h
+++ b/include/linux/spi/spi.h
@@ -424,6 +424,17 @@ struct spi_master {
 #define SPI_MASTER_NO_TX	BIT(2)		/* can't do buffer write */
 #define SPI_MASTER_MUST_RX      BIT(3)		/* requires rx */
 #define SPI_MASTER_MUST_TX      BIT(4)		/* requires tx */
+	/* Controller may support data stripe feature when more than one
+	 * chips are present.
+	 * Setting data stripe will send data in following manner:
+	 * -> even bytes i.e. 0, 2, 4,... are transmitted on lower data bus
+	 * -> odd bytes i.e. 1, 3, 5,.. are transmitted on upper data bus
+	 */
+#define SPI_MASTER_DATA_STRIPE	BIT(7)		/* support data stripe */
+	/* Controller may support asserting more than one chip select at once.
+	 * This flag will enable that feature.
+	 */
+#define SPI_MASTER_BOTH_CS	BIT(8)		/* assert both chip selects */

 	/* lock and mutex for SPI bus locking */
 	spinlock_t		bus_lock_spinlock;
--
2.1.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[LINUX RFC v3 0/4] spi: add dual parallel mode support in Zynq MPSoC GQSPI controller Ranjit Waghmode <ranjit.waghmode@xilinx.com> - 2015-12-14 14:20 +0100
  [LINUX RFC v3 1/4] spi: addng support for data stripe feature in core Ranjit Waghmode <ranjit.waghmode@xilinx.com> - 2015-12-14 14:20 +0100
  [LINUX RFC v3 2/4] mtd: add spi_device instance to spi_nor struct Ranjit Waghmode <ranjit.waghmode@xilinx.com> - 2015-12-14 14:30 +0100
  [LINUX RFC v3 3/4] mtd: spi-nor: add dual parallel mode support Ranjit Waghmode <ranjit.waghmode@xilinx.com> - 2015-12-14 14:30 +0100
  [LINUX RFC v3 4/4] spi: zynqmp: gqspi: add support for dual parallel mode configuration Ranjit Waghmode <ranjit.waghmode@xilinx.com> - 2015-12-14 14:30 +0100

csiph-web