Re: [PATCH 1/1] Remove unneeded "0x" when %pa formatting is used.

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] Remove unneeded "0x" when %pa formatting is used.
Date	2015-12-13 02:20 +0100
Message-ID	<qF3up-1x9-3@gated-at.bofh.it> (permalink)
References	<qyri9-3QA-7@gated-at.bofh.it> <qyOHM-2Bf-15@gated-at.bofh.it> <qADoS-8nQ-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Nov 30, 2015 at 10:33 PM, Dmitry Krivenok
<krivenok.dmitry@gmail.com> wrote:
>>>      if (size > max_size) {
>>>          dev_err(pcie->dev,
>>> -            "res size 0x%pap exceeds max supported size 0x%llx\n",
>>> +            "res size %pap exceeds max supported size 0x%llx\n",
>>
>> %pa also works.
>>
>
> Yes, but AFAIK %pap and %pa are identical (see address_val() in lib/vsprintf.c),
> so I'm not sure I understand your comment.
>
> Did you mean that %pa should be used instead of %pap?
> I see that %pa is used much more often than %pap, but I didn't find any
> evidence that %pap is deprecated.

+Rasmus.

No, it's not, but it explicitly for phys_addr_t (it might be nice to
to have %par, for example for explicitly shown that is for
resource_size_t, Rasmus?).

For my opinion for resources better to use %pa for now, though %pap
will work as well.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/1] Remove unneeded "0x" when %pa formatting is used. Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-13 02:20 +0100

csiph-web