Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1290467
| Path | csiph.com!goblin3!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Robert Jarzmik <robert.jarzmik@free.fr> |
| Newsgroups | linux.kernel |
| Subject | [PATCH] fixup! pinctrl: pxa: pxa2xx: add pin control skeleton |
| Date | Sat, 12 Dec 2015 22:50:01 +0100 |
| Message-ID | <qF0db-7LX-1@gated-at.bofh.it> (permalink) |
| X-Original-To | Daniel Mack <daniel@zonque.org>, Haojian Zhuang <haojian.zhuang@gmail.com>, Robert Jarzmik <robert.jarzmik@free.fr>, Linus Walleij <linus.walleij@linaro.org> |
| X-Me-Helo | belgarion.home |
| X-Me-Date | Sat, 12 Dec 2015 22:43:57 +0100 |
| X-Me-IP | 92.156.1.80 |
| X-Mailer | git-send-email 2.1.4 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 44 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Sat, 12 Dec 2015 22:43:05 +0100 |
| X-Original-Message-ID | <1449956585-17118-1-git-send-email-robert.jarzmik@free.fr> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1290467 |
Show key headers only | View raw
The wrong free functions were used to release temporary buffers. This didn't show up in the normal driver's life. Yet in suspend to RAM, the managed resource list is walked, and as memory was released, the list is corrupted and make the kernel Oops. Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr> --- Linus, if it's time, then this can fixup the commit. If not, I'll provide a better commit message. --- drivers/pinctrl/pxa/pinctrl-pxa2xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pxa/pinctrl-pxa2xx.c b/drivers/pinctrl/pxa/pinctrl-pxa2xx.c index e01914460219..d90e205cf809 100644 --- a/drivers/pinctrl/pxa/pinctrl-pxa2xx.c +++ b/drivers/pinctrl/pxa/pinctrl-pxa2xx.c @@ -292,7 +292,7 @@ static int pxa2xx_build_functions(struct pxa_pinctrl *pctl) if (!pctl->functions) return -ENOMEM; - kfree(functions); + devm_kfree(pctl->dev, functions); return 0; } @@ -328,7 +328,7 @@ static int pxa2xx_build_groups(struct pxa_pinctrl *pctl) memcpy(func->groups, gtmp, ngroups * sizeof(*gtmp)); } - kfree(gtmp); + devm_kfree(pctl->dev, gtmp); return 0; } -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] fixup! pinctrl: pxa: pxa2xx: add pin control skeleton Robert Jarzmik <robert.jarzmik@free.fr> - 2015-12-12 22:50 +0100 Re: [PATCH] fixup! pinctrl: pxa: pxa2xx: add pin control skeleton Linus Walleij <linus.walleij@linaro.org> - 2015-12-15 14:10 +0100
csiph-web