Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1289769

Re: [PATCH] x86/platform/uv: Include clocksource.h for clocksource_touch_watchdog()

Show all headers | View raw

On Fri, Dec 11, 2015 at 12:06 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Andy Lutomirski <luto@kernel.org> wrote:
>
>> diff --git a/arch/x86/include/asm/fixmap.h b/arch/x86/include/asm/fixmap.h
>> index f80d70009ff8..6d7d0e52ed5a 100644
>> --- a/arch/x86/include/asm/fixmap.h
>> +++ b/arch/x86/include/asm/fixmap.h
>> @@ -19,7 +19,6 @@
>>  #include <asm/acpi.h>
>>  #include <asm/apicdef.h>
>>  #include <asm/page.h>
>> -#include <asm/pvclock.h>
>>  #ifdef CONFIG_X86_32
>>  #include <linux/threads.h>
>>  #include <asm/kmap_types.h>
>
> So this change triggered a build failure on 64-bit allmodconfig - fixed via the
> patch below. Your change unearthed a latent bug, a missing header inclusion.
>
> Thanks,
>
>         Ingo
>
> ============>
> From d51953b0873358d13b189996e6976dfa12a9b59d Mon Sep 17 00:00:00 2001
> From: Ingo Molnar <mingo@kernel.org>
> Date: Fri, 11 Dec 2015 09:01:30 +0100
> Subject: [PATCH] x86/platform/uv: Include clocksource.h for clocksource_touch_watchdog()
>
> This build failure triggers on 64-bit allmodconfig:
>
>   arch/x86/platform/uv/uv_nmi.c:493:2: error: implicit declaration of function ‘clocksource_touch_watchdog’ [-Werror=implicit-function-declaration]
>
> which is caused by recent changes exposing a missing clocksource.h include
> in uv_nmi.c:
>
>   cc1e24fdb064 x86/vdso: Remove pvclock fixmap machinery
>
> this file got clocksource.h indirectly via fixmap.h - that stealth route
> of header inclusion is now gone.
>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Ingo Molnar <mingo@kernel.org>

LGTM.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 4/5] x86/vdso: Remove pvclock fixmap machinery Andy Lutomirski <luto@kernel.org> - 2015-12-10 00:20 +0100
  Re: [PATCH 4/5] x86/vdso: Remove pvclock fixmap machinery Paolo Bonzini <pbonzini@redhat.com> - 2015-12-10 10:20 +0100
  [PATCH] x86/platform/uv: Include clocksource.h for  clocksource_touch_watchdog() Ingo Molnar <mingo@kernel.org> - 2015-12-11 09:10 +0100
    Re: [PATCH] x86/platform/uv: Include clocksource.h for clocksource_touch_watchdog() Andy Lutomirski <luto@amacapital.net> - 2015-12-11 18:40 +0100
  [tip:x86/asm] x86/vdso: Remove pvclock fixmap machinery tip-bot for Andy Lutomirski <tipbot@zytor.com> - 2015-12-14 09:20 +0100

csiph-web