Re: [PATCHv3] printf: Add format for 8-byte EUI-64 type

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv3] printf: Add format for 8-byte EUI-64 type
Date	2015-12-11 16:50 +0100
Message-ID	<qEy7f-6pg-3@gated-at.bofh.it> (permalink)
References	<qDW1Y-6ob-5@gated-at.bofh.it> <qDWlk-6vk-7@gated-at.bofh.it> <qEb11-7RF-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

+Rasmus.

On Thu, Dec 10, 2015 at 5:06 PM, Keith Busch <keith.busch@intel.com> wrote:
> On Wed, Dec 09, 2015 at 03:21:40PM -0800, Joe Perches wrote:
>> On Wed, 2015-12-09 at 16:06 -0700, Keith Busch wrote:
>> > MAC addresses may be formed using rules based on EUI-64, which is 2 bytes
>> > longer than a typical 6-byte MAC. This patch adds a long specifier to
>> > the %pM format to support the extended unique identifier.
>> >
>> > Since there are multiple valid possible permutations of format specifiers,
>> > the decoding is done in a loop, and the default ':' separator is
>> > initialized at declaration time. A side effect of this allows 'F' and
>> > 'R' both be specified, so these are appended to the documentation.
>>
>> Just thought of this:
>>
>> An alternative is using a format of "%8phC"
>>
>> Is there a use case for a bluetooth or FDDI EUI-64?
>
> *facepalm*
>
> I didn't know that format, but it satisfies my needs. I am not aware of
> bluetooth or fddi using eui64, so I've no problem withdrawing the patch.
> I'll just fix up the one that depended on it.

Of course you might try to add reversed support for %*ph.

Also you may consider print_hex_dump() [hex_dump_to_buffer()], though
it looks like overkill in particular here.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCHv3] printf: Add format for 8-byte EUI-64 type Keith Busch <keith.busch@intel.com> - 2015-12-10 00:10 +0100
  Re: [PATCHv3] printf: Add format for 8-byte EUI-64 type Joe Perches <joe@perches.com> - 2015-12-10 00:30 +0100
    Re: [PATCHv3] printf: Add format for 8-byte EUI-64 type Keith Busch <keith.busch@intel.com> - 2015-12-10 16:10 +0100
      Re: [PATCHv3] printf: Add format for 8-byte EUI-64 type Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-11 16:50 +0100
  RE: [PATCHv3] printf: Add format for 8-byte EUI-64 type "Elliott, Robert (Persistent Memory)" <elliott@hpe.com> - 2015-12-10 02:50 +0100

csiph-web