Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1289682
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 3/7] ARM: hisi: add dt_machine definition for Hi3519 |
| Date | 2015-12-11 16:30 +0100 |
| Message-ID | <qExNU-6hd-25@gated-at.bofh.it> (permalink) |
| References | <qEqMq-19l-13@gated-at.bofh.it> <qEqMr-19l-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Dec 11, 2015 at 03:45:17PM +0800, Jiancheng Xue wrote:
> add dt_machine definition for hi3519.
>
> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
> ---
> arch/arm/mach-hisi/hisilicon.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/mach-hisi/hisilicon.c b/arch/arm/mach-hisi/hisilicon.c
> index 8cc6215..010d8a2 100644
> --- a/arch/arm/mach-hisi/hisilicon.c
> +++ b/arch/arm/mach-hisi/hisilicon.c
> @@ -81,3 +81,12 @@ static const char *const hip01_compat[] __initconst = {
> DT_MACHINE_START(HIP01, "Hisilicon HIP01 (Flattened Device Tree)")
> .dt_compat = hip01_compat,
> MACHINE_END
> +
> +static const char *const hi3519_compat[] __initconst = {
> + "hisilicon,hi3519",
> + NULL,
> +};
You should just have 1 mach desc with multiple compatible strings to
match against, not 1 mach desc per compatible string.
Rob
> +
> +DT_MACHINE_START(HI3519_DT, "Hisilicon Hi3519")
> + .dt_compat = hi3519_compat,
> +MACHINE_END
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 3/7] ARM: hisi: add dt_machine definition for Hi3519 Jiancheng Xue <xuejiancheng@huawei.com> - 2015-12-11 09:00 +0100
Re: [PATCH v3 3/7] ARM: hisi: add dt_machine definition for Hi3519 Rob Herring <robh@kernel.org> - 2015-12-11 16:30 +0100
Re: [PATCH v3 3/7] ARM: hisi: add dt_machine definition for Hi3519 xuejiancheng <xuejiancheng@huawei.com> - 2015-12-14 03:20 +0100
csiph-web