Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1289615

Re: [PATCH V6 20/26] perf: changing pmu::setup_aux() parameter to include event

Show all headers | View raw

Mathieu Poirier <mathieu.poirier@linaro.org> writes:

> For Coresight ETMv3/4 tracers the event carries information
> about trace modes such as user or kernel space tracing and
> whether tracing is allowed when operating in secure mode.

Ok, so it looks to me that what you're doing in your setup_aux with the
event, you should rather be doing in pmu::event_init(), which takes
event as a parameter and it even makes more sense semantically, because
that bit is really configuring the parameters of tracing and not
capturing, which setup_aux() is more about. And the above paragraph also
sounds very much like it. Since in Coresight there is a very clear
distinction between trace generation (sources) and capturing (sinks) it
should also be possible to structure the code in such a way that the
former are not as closely tied to the latter. Please correct me if I'm
missing something.

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V6 20/26] perf: changing pmu::setup_aux() parameter to include event Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-12-03 22:10 +0100
  Re: [PATCH V6 20/26] perf: changing pmu::setup_aux() parameter to include event Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2015-12-11 15:20 +0100
    Re: [PATCH V6 20/26] perf: changing pmu::setup_aux() parameter to  include event Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-12-11 23:00 +0100

csiph-web