Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1289369

[PATCH 2/2] usb: serial: remove redundant condition

Show all headers | View raw

This patch removes redundant condition.

 (length && length > 5) can be reduced to a single evaluation.

Tested by compilation only.
Caught by cppcheck.

Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
---
 drivers/usb/serial/mos7840.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index 8ac9b55..2c69bfc 100644
--- a/drivers/usb/serial/mos7840.c
+++ b/drivers/usb/serial/mos7840.c
@@ -635,7 +635,7 @@ static void mos7840_interrupt_callback(struct urb *urb)
 	 * Byte 4 IIR Port 4 (port.number is 3)
 	 * Byte 5 FIFO status for both */
 
-	if (length && length > 5) {
+	if (length > 5) {
 		dev_dbg(&urb->dev->dev, "%s", "Wrong data !!!\n");
 		return;
 	}
-- 
2.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] usb: serial: remove redundant conditions "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-11 10:50 +0100
  [PATCH 2/2] usb: serial: remove redundant condition "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-11 10:50 +0100
    Re: [PATCH 2/2] usb: serial: remove redundant condition Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-11 13:40 +0100
      Re: [PATCH 2/2] usb: serial: remove redundant condition "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-11 13:50 +0100
  Re: [PATCH 1/2] usb: serial: remove redundant conditions Johan Hovold <johan@kernel.org> - 2015-12-11 11:20 +0100
    Re: [PATCH 1/2] usb: serial: remove redundant conditions Johan Hovold <johan@kernel.org> - 2015-12-11 11:30 +0100
    Re: [PATCH 1/2] usb: serial: remove redundant conditions "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-11 11:30 +0100

csiph-web