Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1289350

Re: [PATCH 1/4] usb: serial: remove redundant conditions

Show all headers | View raw

On Thu, Dec 10, 2015 at 05:50:09PM -0300, Geyslan G. Bem wrote:
> This patch removes redundant conditions.
> 
>  (!A || (A && B)) is the same as (!A || B).
>  (length && length > 5) can be reduced to a single evaluation.
> 
> Tested by compilation only.
> Caught by cppcheck.
> 
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> ---
>  drivers/usb/serial/io_edgeport.c | 35 ++++++++++++++---------------------
>  drivers/usb/serial/mos7840.c     |  2 +-
>  2 files changed, 15 insertions(+), 22 deletions(-)

Please split this up per driver as I (and Felipe) asked.

You can send these two separate from the rest, and remember to CC
the USB list.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] usb: serial: remove redundant conditions "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 22:00 +0100
  [PATCH 2/4] usb: gadget: remove redundant condition "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 22:00 +0100
  Re: [PATCH 1/4] usb: serial: remove redundant conditions Johan Hovold <johan@kernel.org> - 2015-12-11 10:20 +0100
    Re: [PATCH 1/4] usb: serial: remove redundant conditions "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-11 10:40 +0100

csiph-web