Re: [PATCH v3 20/20] ARM: dts: Add support of bus frequency for exynos4412-trats/odroidu3

From	Chanwoo Choi <cw00.choi@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 20/20] ARM: dts: Add support of bus frequency for exynos4412-trats/odroidu3
Date	2015-12-11 09:40 +0100
Message-ID	<qErp8-1Ja-17@gated-at.bofh.it> (permalink)
References	<qEo7T-84p-11@gated-at.bofh.it> <qEorg-8dZ-5@gated-at.bofh.it> <qEqjn-XY-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2015년 12월 11일 16:20, Krzysztof Kozlowski wrote:
> On 11.12.2015 14:07, Chanwoo Choi wrote:
>> THis patch adds the bus device tree nodes for both MIF (Memory) and INT
>> (Internal) block to enable the bus frequency.
>>
>> The DMC bus is parent device in MIF block using VDD_MIF and the LEFTBUS
>> bus is parent device in INT block using VDD_INT.
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> [linux.amoon: Tested on Odroid U3]
>> Tested-by: Anand Moon <linux.amoon@gmail.com>
>> ---
>>  arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 47 ++++++++++++++++++++++++
>>  arch/arm/boot/dts/exynos4412-trats2.dts         | 48 +++++++++++++++++++++++++
>>  2 files changed, 95 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> index 7bd65026761e..b6818aec7cf9 100644
>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> @@ -501,3 +501,50 @@
>>  &watchdog {
>>  	status = "okay";
>>  };
>> +
>> +&bus_acp {
>> +	devfreq = <&bus_dmc>;
>> +	status = "okay";
>> +};
> 
> I meant put them in proper place, respecting alphabetical order. The 'b'
> comes before 'w'.
> 
> As for the new nodes (bus_XXX) your previous sorting (first parent, then
> passive) was also okay - it had sense. This is up to you. Just put
> everything not at the end of file.

OK. I'll reorder them. Thanks for review.

[snip]

Best Regards,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 20/20] ARM: dts: Add support of bus frequency for  exynos4412-trats/odroidu3 Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-11 06:30 +0100
  Re: [PATCH v3 20/20] ARM: dts: Add support of bus frequency for  exynos4412-trats/odroidu3 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-11 08:30 +0100
    Re: [PATCH v3 20/20] ARM: dts: Add support of bus frequency for  exynos4412-trats/odroidu3 Chanwoo Choi <cw00.choi@samsung.com> - 2015-12-11 09:40 +0100

csiph-web