Re: [PATCH v4 5/5] crypto: AES CBC multi-buffer glue code

From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 5/5] crypto: AES CBC multi-buffer glue code
Date	2015-12-11 04:30 +0100
Message-ID	<qEmz7-6ZR-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <qBlSW-3wb-23@gated-at.bofh.it> <qDD8Z-2iB-5@gated-at.bofh.it> <qDQIX-2Tz-29@gated-at.bofh.it> <qDYwO-7Pf-11@gated-at.bofh.it> <qEj8d-4Em-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Dec 10, 2015 at 08:39:45AM -0800, Tim Chen wrote:
>
> The inner cipher is called synchronously from the outer layer 
> async cipher algorithm in cbc_mb_async_ablk_decrypt via
> 
>         err = crypto_blkcipher_crt(child_tfm)->decrypt(
>                 &rctx->desc, req->dst, req->src, req->nbytes);

We should avoid bypassing the API and directly calling crypto
driver functions like this.

What if you made it a proper ablkcipher and just called it through
the API?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v4 5/5] crypto: AES CBC multi-buffer glue code Tim Chen <tim.c.chen@linux.intel.com> - 2015-12-02 21:10 +0100
  Re: [PATCH v4 5/5] crypto: AES CBC multi-buffer glue code Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-09 04:00 +0100
    Re: [PATCH v4 5/5] crypto: AES CBC multi-buffer glue code Tim Chen <tim.c.chen@linux.intel.com> - 2015-12-09 18:30 +0100
      Re: [PATCH v4 5/5] crypto: AES CBC multi-buffer glue code Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-10 02:50 +0100
        Re: [PATCH v4 5/5] crypto: AES CBC multi-buffer glue code Tim Chen <tim.c.chen@linux.intel.com> - 2015-12-11 00:50 +0100
          Re: [PATCH v4 5/5] crypto: AES CBC multi-buffer glue code Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-11 04:30 +0100
            Re: [PATCH v4 5/5] crypto: AES CBC multi-buffer glue code Tim Chen <tim.c.chen@linux.intel.com> - 2015-12-11 18:00 +0100

csiph-web