Re: [PATCH 1/2] crypto: sahara: fix 64-bit dma_addr_t compilation

Path	csiph.com!news.mixmin.net!feeds.phibee-telecom.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] crypto: sahara: fix 64-bit dma_addr_t compilation
Date	Fri, 11 Dec 2015 04:10:01 +0100
Message-ID	<qEmfL-6MN-3@gated-at.bofh.it> (permalink)
References	<qDsng-44U-27@gated-at.bofh.it>
X-Original-To	Arnd Bergmann <arnd@arndb.de>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	26
Organization	linux.* mail to news gateway
X-Original-Cc	linux-crypto@vger.kernel.org, "David S. Miller" <davem@davemloft.net>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
X-Original-Date	Fri, 11 Dec 2015 11:00:46 +0800
X-Original-Message-ID	<20151211030046.GB10399@gondor.apana.org.au>
X-Original-References	<1707164.bU6CqSGiie@wuerfel>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1289082

Show key headers only | View raw

On Tue, Dec 08, 2015 at 04:23:51PM +0100, Arnd Bergmann wrote:
> The sahara hardware uses DMA descriptors with 32-bit addresses, but
> dma_addr_t is variable size depending on whether we want to support
> any devices that use 64-bit DMA addresses in hardware.
> This means that the definition of the DMA descriptor structure is wrong,
> and we helpfully get a compiler warning about them too:
> 
> drivers/crypto/sahara.c:423:372: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'dma_addr_t {aka long long unsigned int}' [-Wformat=]
> 
> This changes the definition of the sahara_hw_desc and sahara_hw_link
> structures to only contain fixed-length members, which is required
> to make the driver work on ARM LPAE mode, and avoids most of the
> gcc warnings we get.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Both patches applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] crypto: sahara: fix 64-bit dma_addr_t compilation Arnd Bergmann <arnd@arndb.de> - 2015-12-08 16:30 +0100
  [PATCH 2/2] crypto: sahara: fix debug output for 64-bit dma_addr_t Arnd Bergmann <arnd@arndb.de> - 2015-12-08 16:30 +0100
  Re: [PATCH 1/2] crypto: sahara: fix 64-bit dma_addr_t compilation Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-11 04:10 +0100

csiph-web