Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1289077

[PATCH 3/4] perf top: Fix annotation on --stdio

Show all headers | View raw

The ui__has_annotation() inside perf_top__record_precise_ip() should be
removed since it returns true only for TUI (and when sort key has
symbol).  However the 'perf top --stdio' also supports annotation for a
symbol which was specified by 's' key action.

Actually it already does the necessary checks before calling the
function.  So it's ok to get rid of the check here.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/builtin-top.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 586798acf7db..f447e5531f8b 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -189,8 +189,7 @@ static void perf_top__record_precise_ip(struct perf_top *top,
 	if (pthread_mutex_trylock(&notes->lock))
 		return;
 
-	if (ui__has_annotation())
-		err = hist_entry__inc_addr_samples(he, counter, ip);
+	err = hist_entry__inc_addr_samples(he, counter, ip);
 
 	pthread_mutex_unlock(&notes->lock);
 
-- 
2.6.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] perf top: Do not convert address for perf_top__record_precise_ip() Namhyung Kim <namhyung@kernel.org> - 2015-12-11 04:00 +0100
  [PATCH 3/4] perf top: Fix annotation on --stdio Namhyung Kim <namhyung@kernel.org> - 2015-12-11 04:00 +0100
  [PATCH 4/4] perf top: Cleanup condition in perf_top__record_precise_ip() Namhyung Kim <namhyung@kernel.org> - 2015-12-11 04:00 +0100
    Re: [PATCH 4/4] perf top: Cleanup condition in  perf_top__record_precise_ip() Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-12-11 12:40 +0100
  Re: [PATCH 1/4] perf top: Do not convert address for  perf_top__record_precise_ip() Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-12-11 12:40 +0100

csiph-web